Experiment[Draft]- please do not review #99143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsTesting out some conversion changes with #98858
|
DeepakRajendrakumaran
force-pushed
the
Conversion_myBranch
branch
2 times, most recently
from
90fdb49 to
e86f326
Compare
DeepakRajendrakumaran
force-pushed
the
Conversion_myBranch
branch
2 times, most recently
from
9972d2f to
fe545cc
Compare
khushal1996
reviewed
Mar 4, 2024
src/coreclr/jit/morph.cpp
Outdated
| else if (srcType == TYP_DOUBLE && dstType == TYP_UINT) | ||
| { | ||
| /*oper = gtNewCastNode(TYP_LONG, oper, false, TYP_LONG); | ||
| tree = gtNewCastNode(TYP_INT, oper, false, TYP_UINT); |
There was a problem hiding this comment.
Why not invoke the helper directly? afaik, it takes care of the return type...
DeepakRajendrakumaran
force-pushed
the
Conversion_myBranch
branch
3 times, most recently
from
2169219 to
1952925
Compare
# Conflicts: # src/coreclr/inc/jithelpers.h # src/coreclr/jit/morph.cpp # src/coreclr/jit/utils.cpp # src/coreclr/jit/valuenum.cpp # src/coreclr/nativeaot/Runtime/MathHelpers.cpp # src/coreclr/vm/jithelpers.cpp
…hen converting to uint/ulong
DeepakRajendrakumaran
force-pushed
the
Conversion_myBranch
branch
from
1952925 to
0b39611
Compare
khushal1996
reviewed
Mar 7, 2024
| @@ -1735,10 +1738,13 @@ private static double DoubleReminder(double dividend, double divisor) | |||
| return FMod(dividend, divisor); | |||
| } | |||
|
|
|||
| [StackTraceHidden] | |||
There was a problem hiding this comment.
Why do we want to hide the stack trace?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing out some conversion changes with #98858