Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Add RID for Alpine 3.19 / 3.20 #99560

Merged

Conversation

ayakael
Copy link
Contributor

@ayakael ayakael commented Mar 11, 2024

Adds RID for Alpine 3.19 and 3.20

Fixes #96155

Addresses dotnet/dotnet-docker#5243

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 11, 2024
@ayakael ayakael force-pushed the 6.0/alpine-rid-319-320 branch from 0a62800 to d7446ca Compare March 11, 2024 20:11
@ayakael
Copy link
Contributor Author

ayakael commented Mar 11, 2024

I've skipped main because we're not interested in this on main anymore, but tell me if I should up-port this somewhere.

@agocke
Copy link
Member

agocke commented Mar 11, 2024

I've skipped main because we're not interested in this on main anymore, but tell me if I should up-port this somewhere.

Unfortunately we might need to push this forward because of the back-compat switch.

@ayakael
Copy link
Contributor Author

ayakael commented Mar 11, 2024

I've skipped main because we're not interested in this on main anymore, but tell me if I should up-port this somewhere.

Unfortunately we might need to push this forward because of the back-compat switch.

This PR doesn't apply to master since there are no more non-portable RIDs in RID graph. Do you mean I have to up-port to 7.0?

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayakael I added the missing required Microsoft.NETCore.Platforms change.

I asked if we would still want a 7.0 equivalent RID update and it has been decided that we won't take one, as that branch only has one more month to live before EOL and it is currently only taking security fixes.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Mar 11, 2024
@elinor-fung
Copy link
Member

I've skipped main because we're not interested in this on main anymore, but tell me if I should up-port this somewhere.

Unfortunately we might need to push this forward because of the back-compat switch.

This PR doesn't apply to master since there are no more non-portable RIDs in RID graph. Do you mean I have to up-port to 7.0?

Agree we shouldn't need to apply to main. For the back-compat switch in 8.0+, the intent was that it would use to the 'frozen' non-portable RID graph - and we wouldn't update that non-portable RID graph (anything new should go through the new portable behaviour).

@carlossanlop
Copy link
Member

@ayakael there is a build failure:

##[error]src/libraries/Microsoft.NETCore.Platforms/src/runtimeGroups.props(285,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) The generated CompatibilityMap differs from runtime.compatibility.json and UpdateRuntimeFiles was not specified.  Please specify UpdateRuntimeFiles=true to commit the changes.

@ayakael
Copy link
Contributor Author

ayakael commented Mar 12, 2024

@elinor-fung I right, I see the lack of ppc64le + armv6 for the 6.0 release. Thanks for catching that!

@ayakael ayakael force-pushed the 6.0/alpine-rid-319-320 branch from 729e9bd to 7d5b844 Compare March 12, 2024 01:23
@carlossanlop carlossanlop merged commit 757ccc2 into dotnet:release/6.0-staging Mar 12, 2024
116 of 123 checks passed
@elinor-fung elinor-fung linked an issue Mar 12, 2024 that may be closed by this pull request
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RIDs for Alpine 3.19
4 participants