Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attributes for IsDynamicCodeSupported feature switch #99641

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Mar 12, 2024

And remove some warning suppression pragmas.

Fixes #97273 (the analyzer will now be able to see that IsDynamicCodeCompiled guards APIs annotated with RequiresDynamicCodeAttribute).

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Mar 12, 2024
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

…/TypeUtils.cs

Co-authored-by: Austin Wise <AustinWise@gmail.com>
@sbomer sbomer merged commit eb864bf into dotnet:main Mar 13, 2024
179 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positives for IL3050, despite runtime feature checks
3 participants