[release/8.0-staging] disable optimizations for PopCount #99832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
avoid using an optimization which might fail on non-SSE4 cpus.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jeffschwMSFT
approved these changes
Mar 15, 2024
|
relevant VS Developer Community feedback item : https://developercommunity.visualstudio.com/t/Visual-Studio-1793-crashes-during-star/10614986 |
carlossanlop
pushed a commit
to carlossanlop/runtime
that referenced
this pull request
Mar 18, 2024
* disable optimizations for PopCount avoid using an optimization which might fail on non-SSE4 cpus. * remove whitespace for jit-format --------- Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
carlossanlop
added a commit
that referenced
this pull request
Mar 18, 2024
* disable optimizations for PopCount avoid using an optimization which might fail on non-SSE4 cpus. * remove whitespace for jit-format --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #99796 to release/8.0-staging
/cc @mangod9
Customer Impact
Regression
This was a regression in 8.0.3 due to a compiler update which caused popcnt instruction from being emitted. This causes .NET applications to stop working on cpus without SSE4 support.
Testing
Verified locally that popcnt is not being generated, and also that inlining for these methods is disabled.
Risk
[Low]