Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] disable optimizations for PopCount #99926

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

carlossanlop
Copy link
Member

Cherry-pick of #99832 to include it in the release/8.0 branch for the April Release.

@jeffschwMSFT @mangod9 @mmitche @vseanreesermsft

* disable optimizations for PopCount

avoid using an optimization which might fail on non-SSE4 cpus.

* remove whitespace for jit-format

---------

Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Mar 18, 2024
@carlossanlop carlossanlop added this to the 8.0.4 milestone Mar 18, 2024
@carlossanlop carlossanlop self-assigned this Mar 18, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carlossanlop carlossanlop merged commit fd8f5b5 into dotnet:release/8.0 Mar 18, 2024
14 of 85 checks passed
@carlossanlop carlossanlop deleted the CherryPickPopCount branch March 18, 2024 19:51
@jeffschwMSFT jeffschwMSFT mentioned this pull request Mar 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants