Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roundtripping delegates through a native function pointer #164

Closed
MichalStrehovsky opened this issue Oct 9, 2020 · 4 comments · Fixed by dotnet/runtime#98614 or dotnet/runtime#99185
Closed

Roundtripping delegates through a native function pointer #164

MichalStrehovsky opened this issue Oct 9, 2020 · 4 comments · Fixed by dotnet/runtime#98614 or dotnet/runtime#99185
Labels
area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation bug Something isn't working

Comments

@MichalStrehovsky
Copy link
Member

Interop/MarshalAPI/FunctionPointer/FunctionPtrTest
@MichalStrehovsky MichalStrehovsky added bug Something isn't working area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation labels Oct 9, 2020
@MichalStrehovsky MichalStrehovsky mentioned this issue Jan 25, 2022
Closed
@filipnavara
Copy link
Member

The test doesn't seem to exist anymore at this location. Would it make sense to remove the exclusions and close the issue?

@jkotas
Copy link
Member

jkotas commented Feb 17, 2024

Yes

filipnavara added a commit to filipnavara/runtime that referenced this issue Feb 17, 2024
@filipnavara
Remove test exclusion for dotnet/runtimelab#164
249d405
@filipnavara filipnavara mentioned this issue Feb 17, 2024
Merged
jkotas pushed a commit to dotnet/runtime that referenced this issue Feb 17, 2024
@filipnavara
Remove test exclusion for dotnet/runtimelab#164 (#98614)
1ad22a5
@MichalStrehovsky
Copy link
Member Author

This is not resolved. The test was just converted to an ActiveIssue but still references this issue number.

@filipnavara
Copy link
Member

Thanks for pointing that out. I was looking for the test since it exercises a broken code path on ARM.

For posterity, the new location:
https://github.com/dotnet/runtime/blob/25b1249e4edb3fef50be35df88fcb363d42f8574/src/tests/Interop/MarshalAPI/FunctionPointer/FunctionPointer.cs#L30-L68

jkotas added a commit to jkotas/runtime that referenced this issue Mar 2, 2024
@jkotas
[NativeAOT] Delegate bug fixes
fa3d1ec 
- Fix Delegate.Method and Delegate.Target for marshalled delegates
- Add tests and fixes for corner various delegate corner case behaviors
- Delete runtime test for GetInvocationList since there is a better test coverage for this API under libraries

Fixes dotnet/runtimelab#164
@jkotas jkotas mentioned this issue Mar 2, 2024
Merged
jkotas added a commit to dotnet/runtime that referenced this issue Mar 9, 2024
@jkotas
[NativeAOT] Delegate bug fixes (#99185)
cc17166 
- Fix Delegate.Method and Delegate.Target for marshalled delegates
- Add tests and fixes for various delegate corner case behaviors
- Delete runtime test for GetInvocationList since there is a better test coverage for this API under libraries
- Delete `m` prefix on System.Delegate member fields

Fixes dotnet/runtimelab#164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-NativeAOT-coreclr .NET runtime optimized for ahead of time compilation bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@filipnavara @jkotas @MichalStrehovsky