NativeAOT-LLVM: Fix publishing of additional wasm files #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleAccretion
approved these changes
Jan 10, 2023
|
@MichalStrehovsky I don't know what I clicked to tag you here... You can ignore it, it wasn't intentional |
|
I suspect it is automatic tagging based on the code owners file. We should probably delete that / mute it / something else. |
Yup, the set-up a new experiment doc suggests deleting it: https://github.com/dotnet/runtimelab/blob/docs/CreateAnExperiment.md I would probably rename it instead to avoid edit-delete merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the comment at #2121 (comment) where the js and wasm files do not get copied to the publish folder.
It changes condition of the additional copies to use TargetArchitecure=wasm. (Platform is AnyCPU now)
cc @dotnet/nativeaot-llvm