Type discovery using semantic model instead of string comparisons #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwkt
changed the title
layomia
reviewed
Aug 3, 2020
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Show resolved
Hide resolved
src/libraries/System.Text.Json/System.Text.Json.SourceGeneration/JsonSourceGenerator.cs
Show resolved
Hide resolved
layomia
reviewed
Aug 4, 2020
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Show resolved
Hide resolved
...ies/System.Text.Json/System.Text.Json.SourceGeneration.UnitTests/JsonSourceGeneratorTests.cs
Show resolved
Hide resolved
layomia
approved these changes
Aug 7, 2020
scalablecory
pushed a commit
that referenced
this pull request
Sep 22, 2020
Syncs the latest internal Windows OS changes.
MichalStrehovsky
added a commit
to MichalStrehovsky/runtimelab
that referenced
this pull request
Oct 15, 2021
Introduces common helpers to rewrite and analyze signatures. Local variable signatures are analyzed & rewritten in the first commit. The second commit shows how are we going to hook up the other kinds of signatures into the common code since all signatures somehow deal with encoding types and we don't want to duplicate that code. I hooked it up into MethodDefinition and MemberReference. The third commit enables @tlakollo's disabled test since we now support it. Fixes dotnet#4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 things in this PR, addresses #27