Add parent cs folders to the paths of all the samples used in the Json-DateTime doc

[layomia]

Addresses #1412 (comment).
Used in dotnet/docs@3a082aa.

[ahsonkhan]

Why did we decide to call all the cs files Program.cs and move the name to a folder instead?

cc @mairaw, @rpetrusha

[rpetrusha]

Having csharp files in a cs directory allows for multiple languages to share the same parent directory (for example, we can now add a vb directory for a vb example). It also allows the language of the example to be readily determined without having to look at file extensions, and is useful for CI tools.

[rpetrusha]

Thank you for making this change, @layomia. Are you planning to submit a PR that changes the path to the samples where they're used in the docs repo? Although I've approved, we should wait to merge until that PR is ready.

[ahsonkhan]

Having csharp files in a cs directory allows for multiple languages to share the same parent directory (for example, we can now add a vb directory for a vb example). It also allows the language of the example to be readily determined without having to look at file extensions, and is useful for CI tools.

I understand that we want to have language specific sub-directories.

However, this PR is changing the file names too:

snippets/standard/datetime/json/computing-with-jsondocument-error.cs → snippets/standard/datetime/json/computing-with-jsondocument-error/cs/Program.cs

How about something like the following (rather than calling them all Program.cs within a directory that contains the name)? We can still have the cs subdirectory.
snippets/standard/datetime/json/cs/computing-with-jsondocument-error.cs

Also, what about the existing samples? They look to be in the csharp directory:
https://github.com/dotnet/samples/tree/master/snippets/csharp/api
We also have:
https://github.com/dotnet/samples/tree/master/csharp

Why are we using the "standard" directory for these? I don't really understand the folder layout of this repo, tbh.

And the last time I added a sample, I ended up putting it in "core":
https://github.com/dotnet/samples/tree/master/core/json

See #492 (comment) from @BillWagner / @richlander

[layomia]

@rpetrusha

Are you planning to submit a PR that changes the path to the samples where they're used in the docs repo?

Yes, dotnet/docs#14056 changes the paths.

Can you please advise on the correct path structure, i.e.

snippets/standard/datetime/json/computing-with-jsondocument-error/cs/Program.cs (current), versus
snippets/standard/datetime/json/cs/computing-with-jsondocument-error.cs,

and also the correct directory to place these samples, re @ahsonkhan's comment: #1418 (comment).

[ahsonkhan]

@rpetrusha - any updates on this? If it makes no difference, I am fine with the current changes as is. I'd like to get this merged.

[ahsonkhan]

We can defer any further folder/file name restructuring, imo.

[mairaw]

As I mentioned in the previous PR where we discussed this, I think the folder name should be csharp, so it matches the language identifier and other paths where we've been using this:

e.g.
https://github.com/dotnet/samples/tree/master/csharp
https://github.com/dotnet/samples/tree/master/snippets/csharp
https://github.com/dotnet/samples/tree/master/snippets/standard/base-types/format-strings/csharp

Thoughts?

[ahsonkhan]

Seems reasonable to me. For example, I would be fine with the following layout:
https://github.com/dotnet/samples/tree/master/snippets/standard/datetime/json/csharp/computing-with-jsondocument-error/Program.cs

https://github.com/dotnet/samples/tree/master/snippets/standard/datetime/json/csharp/datetime-converter-examples/example1/Program.cs
etc.