- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.2k
Create sync and async sample for using Utf8JsonReader. #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is great.
I had one small suggestion, and then once you've address Stephen's comment, we'll merge.
| This is ready to merge. | 
| I think this sample should be in core directory. Why in the csharp directory? | 
| Other than the folder location, this is ready to go. It likely fits better under core than under C# because the concepts it explains are more about the library than about the language. Is there an article that will accompany this sample? Where will that go? We try to mirror the sample folder structure with the docs folder structure. That can help us find the right location. | 
| 
 
 Done. Moved to a new "whats new in 30" folder. | 
| Sorry to be so picky and for not being specific ... I was expecting something more like ~/core/json | 
| 
 That's easy enough to fix :) | 
Summary
Utf8JsonReader sample showcasing how to use the APIs to accompany the .NET Core 3.0 preview 1 release.
Borrowed the data from: https://github.com/Hipo/university-domains-list (MIT License)
E:\GitHub\Fork\samples\snippets\csharp\how-to\json> dotnet run -c ReleaseExpected output:
cc @richlander, @glennc, @terrajobst, @stephentoub