Fixes #1437 (typo in field name) #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
Thank you for jumping on the issue and also noticing the extra typo @alex-basiuk. Your contribution should be live within a day.
mairaw
reviewed
Dec 20, 2018
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="SimpleWebToken"/> class. | ||
| /// This is internal contructor is only called from the <see cref="SimpleWebTokenHandler"/> when reading a token received from the wire. | ||
| /// This is internal constructor is only called from the <see cref="SimpleWebTokenHandler"/> when reading a token received from the wire. |
There was a problem hiding this comment.
Just noticed this if you'd like to commit my suggestion while you're at it
Suggested change
| /// This is internal constructor is only called from the <see cref="SimpleWebTokenHandler"/> when reading a token received from the wire. | |
| /// This is an internal constructor that is only called from the <see cref="SimpleWebTokenHandler"/> when reading a token received from the wire. |
mairaw
reviewed
Dec 20, 2018
| /// This is internal contructor is only called from the <see cref="SimpleWebTokenHandler"/> when reading a token received from the wire. | ||
| /// This is internal constructor is only called from the <see cref="SimpleWebTokenHandler"/> when reading a token received from the wire. | ||
| /// </summary> | ||
| /// <param name="properties">The collection represents all the key value pairs in the token.</param> |
There was a problem hiding this comment.
argh one more 😄
Suggested change
| /// <param name="properties">The collection represents all the key value pairs in the token.</param> | |
| /// <param name="properties">The collection representing all the key value pairs in the token.</param> |
There was a problem hiding this comment.
@mairaw Sure, fixed a couple of more typos, hope you don't mind.
|
|
mairaw
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes dotnet/dotnet-api-docs#1437 (Field Name Typo)