Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting net5 using net6 SDK causes pack failure #19665

Closed
stefanloerwald opened this issue Aug 11, 2021 · 14 comments
Closed

Targeting net5 using net6 SDK causes pack failure #19665

stefanloerwald opened this issue Aug 11, 2021 · 14 comments
Assignees
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Area-External

Comments

@stefanloerwald
Copy link

stefanloerwald commented Aug 11, 2021

To reproduce, create the empty files Component.razor and Component.razor.css (no content required).

As the csproj file use

<Project Sdk="Microsoft.NET.Sdk.Razor">

  <PropertyGroup>
    <TargetFramework>net5.0</TargetFramework>
    <Nullable>enable</Nullable>
  </PropertyGroup>


  <ItemGroup>
    <SupportedPlatform Include="browser" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="5.0.9" />
  </ItemGroup>

</Project>

Then run dotnet build and afterwards dotnet pack. The latter will fail with the error message

C:\Program Files\dotnet\sdk\6.0.100-preview.7.21379.14\Sdks\Microsoft.NET.Sdk.Razor\build\netstandard2.0\Microsoft.NET.Sdk.Razor.StaticWebAssets.5_0.targets(436,5):
error : Static web asset 'C:\project\obj\Debug\net5.0\scopedcss\projectbundle\RazorClassLibrary1.bundle.scp.css' has invalid source type ''. [C:\project\project.csproj]

This is using SDK 6.0.100-preview.7.21379.14.

@SonicGD
Copy link

SonicGD commented Aug 12, 2021

We have the same issue. I tried daily build 6.0.100-rc.1.21411.30 but error still present.

SonicGD added a commit to sitkoru/Sitko.Blockly that referenced this issue Aug 12, 2021
@marcpopMSFT marcpopMSFT self-assigned this Aug 24, 2021
@marcpopMSFT marcpopMSFT added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Aug 24, 2021
@marcpopMSFT marcpopMSFT removed their assignment Aug 24, 2021
@mkArtakMSFT
Copy link
Member

Thanks for contacting us.
@javiercn can you please look into this? Thanks!

@mkArtakMSFT mkArtakMSFT removed the untriaged Request triage from a team member label Aug 31, 2021
@javiercn
Copy link
Member

This was fixed in RC1

@javiercn
Copy link
Member

@stefanloerwald can you try a nightly build? This is a known limitation we introduced in preview7 as we were doing significant work in the area and we had to scope it for the milestone

@stefanloerwald
Copy link
Author

Seems to work with rc1: https://github.com/stefanloerwald/dotnet-sdk-issue-19665/actions/runs/1189053349

@javiercn javiercn closed this as completed Sep 1, 2021
@stefanloerwald
Copy link
Author

It seems like the fix that was in RC1 previously was reverted? With current RC1, I can reproduce the issue again, see https://github.com/stefanloerwald/dotnet-sdk-issue-19665/runs/3618381368?check_suite_focus=true

When I fetch from the "daily" stream I get rc.1.21417.19, with which there is no issue. If I use 6.0.100-rc.1.21458.32, which to the best of my knowledge is the official RC1 version, I get the error.

@javiercn
Copy link
Member

@stefanloerwald I think this was "partially" fixed on RC1 and is truly (hopefully) fixed for good in RC2.

Can you give it a try using RC2 nightly bits?

@stefanloerwald
Copy link
Author

Hi @javiercn,

It is unclear to me how I could try RC2. When I last ran the workflow, the daily stream still gave me the RC1 version. The relevant workflow part is

 daily:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2.3.4
    - name: Setup .NET Core
      run: |
        wget https://dot.net/v1/dotnet-install.sh
        bash ./dotnet-install.sh --channel '6.0' --quality 'daily'
    - name: Install dependencies
      run: dotnet restore
    - name: Build
      run: dotnet build
    - name: Pack
      run: dotnet pack

If you could tell me how to adapt that for RC2, I'm happy to make the adjustments and let it run.

@javiercn
Copy link
Member

@stefanloerwald something like this should do .\dotnet-install.ps1 -Channel '6.0' -Version 6.0.100-rc.2.21465.13 -InstallDir .\dotnet-sdk-6.0.100-rc.2.21465.13 (note I'm using the powershell version)

@stefanloerwald
Copy link
Author

Specifying the version seems to work in the workflow too. Seems like the issue is not in RC2: https://github.com/stefanloerwald/dotnet-sdk-issue-19665/runs/3621929948?check_suite_focus=true

Let's hope it stays like that...

@javiercn
Copy link
Member

Yes, we don't plan to make changes in that area unless we really have to for the rest of 6.0. The initial partial fix was the result of a badly authored test that we improved in RC2 (along with a more robust fix), so hopefully things should be ok.

SonicGD added a commit to sitkoru/Sitko.Blockly that referenced this issue Sep 27, 2021
@robertmclaws
Copy link

@javiercn How do you get Azure DevOps to download SDKs this way? I put that version in the "Use .NET Core" task and it says "sdk version matching 6.0.100-rc.2.21465.13 could not be found."

Thanks!

@javiercn
Copy link
Member

@robertmclaws that build is from like a month ago, I'm not sure how many we retain. You can use the latest available RC2 version which is 6.0.100-rc.2.21505.1

@robertmclaws
Copy link

No worries, RC2 just officially came out, so we're upgrading now. Thanks!

sitkobot added a commit to sitkoru/Sitko.Blockly that referenced this issue Jan 13, 2022
# 1.0.0-beta.1 (2022-01-13)

### Bug Fixes

* **antdesign:** add hints to block fields ([f84d944](f84d944))
* **antdesign:** drop AntBlockFormItem, use AntFormItem from Sitko.Core ([2280870](2280870))
* **blazor:** forbid moving disabled block ([a106c02](a106c02))
* **blazor:** let's try rc2 to workaround dotnet/sdk#19665 ([0ef1b83](0ef1b83))
* **demo:** configure form comparison for blocks ([ce46946](ce46946))

### Features

* **.net:** upgrade to .NET 6.0.0-rc.2 ([7a46c70](7a46c70))
* **antdesign:** add title to block icon ([07e4c92](07e4c92))
* **antdesign:** add titles to block control buttons ([ccec1fc](ccec1fc))
* **antdesign:** update to latest core and blazor changes ([dd700b2](dd700b2))
* **blazor:** allow override FormComponent and DisplayComponent in inheritors ([cc90981](cc90981))
* **blazor:** no need to pass form into blockly form ([5694056](5694056))
* **blazor:** refactor BlazorBlockDescriptor for better type checks ([70b1393](70b1393))
* **blazor:** refactor BlockForm for beter type checks ([46387b8](46387b8))
* **blocks:** add form options to disable specific block type deletion and moving ([a6a41ca](a6a41ca))
* **blocks:** move block priority and max count out of descriptor and into metadata ([0ff5397](0ff5397))
* **core:** .NET 6 RC1 ([e0d246c](e0d246c))
* **core:** upd Sitko.Core to 8.2.1 and AntDesign to 0.9.4 ([a196a76](a196a76))
* **core:** upd Sitko.Core to 8.3.0 ([4382e36](4382e36))
* **core:** upd Sitko.Core to 8.3.1 ([2e75260](2e75260))
* **core:** upd Sitko.Core to 8.5.0 ([45d7859](45d7859))
* **core:** upd Sitko.Core to 8.6.1 ([94775f6](94775f6))
* **core:** update Sitko.Core to 8.8.0 ([3486da9](3486da9))
* **demo:** demo new form options ([5f371f6](5f371f6))
* **demo:** update AntDesign.ProLayout from 0.1.8 to 0.1.10 ([7f70c28](7f70c28))
* **display:** move ShouldRender and ShouldRenderNext to block instead of descriptor ([96055b7](96055b7))
* **display:** remove entity from block list context cause it's never used ([c258cca](c258cca))
* **display:** remove ListContext, make List options required ([619a399](619a399))
* **forms:** add delete event to block forms ([29b295c](29b295c))
* **js:** update js deps ([a1884d3](a1884d3))
* semantic-release ([c6afb5c](c6afb5c))
* Sitko.Core 8.36.1 ([806a791](806a791))
* target .NET 6 only, move common settings to Directory.Build.props ([d1ee2d0](d1ee2d0))
* update HtmlAgilityPack from 1.11.37 to 1.11.39 ([d578fe1](d578fe1))
* update js deps ([e914f87](e914f87))

### BREAKING CHANGES

* .NET 6 only
sitkobot added a commit to sitkoru/Sitko.Blockly that referenced this issue Aug 5, 2022
# 1.0.0 (2022-08-05)

### Bug Fixes

* add custom twitch icon ([7d9252b](7d9252b))
* add custom twitch icon ([819da36](819da36))
* **antdesign:** add hints to block fields ([f84d944](f84d944))
* **antdesign:** drop AntBlockFormItem, use AntFormItem from Sitko.Core ([2280870](2280870))
* **blazor:** forbid moving disabled block ([a106c02](a106c02))
* **blazor:** let's try rc2 to workaround dotnet/sdk#19665 ([0ef1b83](0ef1b83))
* **blazor:** remove default file types from file options, extend default image types ([1a3bbea](1a3bbea))
* **ci:** fix paths to csproj ([9014590](9014590))
* **demo:** configure form comparison for blocks ([ce46946](ce46946))
* **demo:** fix mudblazor connection ([045be01](045be01))
* **demo:** remove duplicated mud components ([88282c6](88282c6))
* **demo:** upd demo to use correct layout and components ([18a02a0](18a02a0))
* fix blocks visibility ([e864a11](e864a11))
* fixed brands icons ([b066788](b066788))
* fixed disabled visibility ticket ([2fa6195](2fa6195))
* fixed displaying delete popup msg ([6b90733](6b90733))
* fixed some icons ([f6b5a41](f6b5a41))
* **mudblazor:** fix add icon display ([98371fb](98371fb))
* **mudblazor:** fix carousel parameters ([cf81259](cf81259))
* **mudblazor:** fix paths to resources ([6b06bb1](6b06bb1))
* **mudblazor:** fix tag case ([a798084](a798084))
* **mudblazor:** remove duplicate validation messages ([24144e3](24144e3))
* **mudblazor:** rename extensions methods ([313d445](313d445))
* **mudblazor:** rework enabled-disabled blocks ([2e3452a](2e3452a))
* **mudblazor:** set correct mode for quote picture input ([857c85d](857c85d))
* **mudblazor:** set For and HelperText on form fields ([b9017fe](b9017fe))
* **mudblazor:** update file inputs ([a96f00a](a96f00a))
* **mudblazor:** use HelperText instead of Tooltip, add For in MudYoutubeBlockForm.razor ([7ffff16](7ffff16))
* rename resources Ant to Mud ([d164e4a](d164e4a))
* **tests:** preinstall GitHubActionsTestLogger ([9e78480](9e78480))

### Features

* **.net:** upgrade to .NET 6.0.0-rc.2 ([7a46c70](7a46c70))
* add mudblazor package to ci ([311c1a0](311c1a0))
* add mudblazor package to ci ([6dcb6c4](6dcb6c4))
* add MudBlazor to demo project ([786907a](786907a))
* add Sitko.Blockly.MudBlazor project ([0f3e8e1](0f3e8e1))
* **antdesign:** add title to block icon ([07e4c92](07e4c92))
* **antdesign:** add titles to block control buttons ([ccec1fc](ccec1fc))
* **antdesign:** fix validation messages ([b7004f0](b7004f0))
* **antdesign:** support external custom icons ([624cc0c](624cc0c))
* **antdesign:** update to latest core and blazor changes ([dd700b2](dd700b2))
* **antdesign:** use new string icons ([0092c2d](0092c2d))
* **blazor:** allow override FormComponent and DisplayComponent in inheritors ([cc90981](cc90981))
* **blazor:** move Icon to core descriptor, make it string ([9b16f52](9b16f52))
* **blazor:** no need to pass form into blockly form ([5694056](5694056))
* **blazor:** refactor BlazorBlockDescriptor for better type checks ([70b1393](70b1393))
* **blazor:** refactor BlockForm for beter type checks ([46387b8](46387b8))
* **blocks:** add form options to disable specific block type deletion and moving ([a6a41ca](a6a41ca))
* **blocks:** move block priority and max count out of descriptor and into metadata ([0ff5397](0ff5397))
* **ci:** update actions/setup-node to v3 ([15bd511](15bd511))
* **core:** .NET 6 RC1 ([e0d246c](e0d246c))
* **core:** Sitko.Core 9.0.0-beta.19 ([924eb3b](924eb3b))
* **core:** Sitko.Core 9.0.0-beta.2 ([9104227](9104227))
* **core:** Sitko.Core 9.0.0-beta.5 ([d220b92](d220b92))
* **core:** Sitko.Core 9.0.0-beta.9 ([9313d5a](9313d5a))
* **core:** upd Sitko.Core to 8.2.1 and AntDesign to 0.9.4 ([a196a76](a196a76))
* **core:** upd Sitko.Core to 8.3.0 ([4382e36](4382e36))
* **core:** upd Sitko.Core to 8.3.1 ([2e75260](2e75260))
* **core:** upd Sitko.Core to 8.5.0 ([45d7859](45d7859))
* **core:** upd Sitko.Core to 8.6.1 ([94775f6](94775f6))
* **core:** update Sitko.Core to 8.8.0 ([3486da9](3486da9))
* **demo:** add launchSettings.json to git ([fd964f9](fd964f9))
* **demo:** add version to resources urls ([71b4f28](71b4f28))
* **demo:** demo new form options ([5f371f6](5f371f6))
* **demo:** update AntDesign.ProLayout from 0.1.8 to 0.1.10 ([7f70c28](7f70c28))
* **display:** move ShouldRender and ShouldRenderNext to block instead of descriptor ([96055b7](96055b7))
* **display:** remove entity from block list context cause it's never used ([c258cca](c258cca))
* **display:** remove ListContext, make List options required ([619a399](619a399))
* **forms:** add delete event to block forms ([29b295c](29b295c))
* **js:** update js deps ([a1884d3](a1884d3))
* make demo use mud ([ad86258](ad86258))
* move to Sitko.Core 9 ([531806d](531806d))
* **mudblazor:** rename root namespace MudBlazorComponents to prevent collision with MudBlazor package namespace ([d6a05f6](d6a05f6))
* **mudblazor:** use new Label and HelperText in MudFileUpload ([caf7522](caf7522))
* **mudblazor:** use new MudValidationMessage ([4952893](4952893))
* **mudblazor:** use new string icons ([4738a8f](4738a8f))
* project files added ([50aa944](50aa944))
* semantic-release ([c6afb5c](c6afb5c))
* Sitko.Core 8.36.1 ([806a791](806a791))
* Sitko.Core 9.7.1 ([022943d](022943d))
* target .NET 6 only, move common settings to Directory.Build.props ([d1ee2d0](d1ee2d0))
* update blocks for mud blazor ([3456112](3456112))
* update forms to mudblazor ([023a11e](023a11e))
* update HtmlAgilityPack from 1.11.37 to 1.11.39 ([d578fe1](d578fe1))
* update js deps ([e914f87](e914f87))

### BREAKING CHANGES

* .NET 6 only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Area-External
Projects
None yet
Development

No branches or pull requests

6 participants