Fix SDK version parsing from global.json in install script on macOS #12339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running install script
scripts/obtain/dotnet-install.sh
withjsonfile
argument works on macOS only whensdk
section has a single propertyversion
. Whensdk
section has multiple properties, for example,a version is detected as
5.0.100-preview.6.20310.4allowPrerelease:truerollForward:major
.Also, in a case when
version
is not the first property insdk
a version can not be detected returning an errordotnet_install: Error: Unable to find the SDK:version node in `global.json`
.The problem seems to be in line:
On macOS, echo does not have a
-e
argument, and all lines of key-value pairs insdk_list
are merged into a single line. So, removing it seems to fix it. I don't have a Linux to test the changes, but I hope CI will catch any issues on Linux.