The 'PushToBlobFeed' call cannot find the NuPkgs #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utputPath" [see: PushToBlobFeed.targets]
The 'PushToBlobFeed' call cannot find the NuPkg because "OutputPath" is changed.
johnbeisner
changed the title
livarcocc
reviewed
Nov 15, 2017
| @@ -1,8 +1,8 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <ItemGroup> | |||
| <ItemsToPushGlobPattern Include="$(OutputPath)Packages\Microsoft.NET.Sdk.*.nupkg" /> | |||
| <ItemsToPushGlobPattern Include="$(OutputPath)Packages\Microsoft.NET.Build.Extensions.*.nupkg" /> | |||
| <ItemsToPushGlobPattern Include="$(RepositoryRootDirectory)bin\$(Configuration)\Packages\Microsoft.NET.Sdk.*.nupkg" /> | |||
There was a problem hiding this comment.
Why is it outputpath does not work here? This is duplicating this information, which is not ideal.
johnbeisner
requested review from
nguerrera,
dsplaisted,
livarcocc,
wli3 and
tannergooding
tannergooding
approved these changes
Nov 15, 2017
JL03-Yue
pushed a commit
that referenced
this pull request
Mar 19, 2024
[main] Update dependencies from dotnet/roslyn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'PushToBlobFeed' call cannot find the NuPkgs because "OutputPath" changes.