Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'PushToBlobFeed' call cannot find the NuPkgs #1736

Merged
merged 2 commits into from
Nov 15, 2017
Merged

The 'PushToBlobFeed' call cannot find the NuPkgs #1736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cfdba9
"TargetFramework" is not needed; moreover it changes the property: "O…
Nov 15, 2017
14357df
Put back "TargetFramework" for the 'restore' call.
Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/PushToBlobFeed.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<ItemGroup>
<ItemsToPushGlobPattern Include="$(OutputPath)Packages\Microsoft.NET.Sdk.*.nupkg" />
<ItemsToPushGlobPattern Include="$(OutputPath)Packages\Microsoft.NET.Build.Extensions.*.nupkg" />
<ItemsToPushGlobPattern Include="$(RepositoryRootDirectory)bin\$(Configuration)\Packages\Microsoft.NET.Sdk.*.nupkg" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it outputpath does not work here? This is duplicating this information, which is not ideal.

<ItemsToPushGlobPattern Include="$(RepositoryRootDirectory)bin\$(Configuration)\Packages\Microsoft.NET.Build.Extensions.*.nupkg" />
</ItemGroup>

<Target Name="PushToBlobFeed" >
Expand Down