Skip to content

Simplify preview warning #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2018
Merged

Simplify preview warning #2286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43fd6a4
Simplify preview warning
richlander Apr 30, 2018
edbb8dd
Update XLF
nguerrera Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@
<comment>{StrBegin="NETSDK1056: "}</comment>
</data>
<data name="UsingPreviewSdkWarning" xml:space="preserve">
<value>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</value>
<value>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</value>
Copy link
Member

@dsplaisted dsplaisted May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richlander The aka.ms link here redirects to https://docs.microsoft.com/en-us/dotnet/core/tools/global-json, which is just a generic global.json reference. Is that the intent or will there be a different page more specific to .NET Core previews?

Copy link
Contributor Author

@nguerrera nguerrera May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mairaw

Copy link
Contributor

@mairaw mairaw May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft's style guide asks for contractions (https://docs.microsoft.com/en-us/style-guide/word-choice/use-contractions):
You are -> You're

@dsplaisted I wasn't aware of that link going to our topic until a customer got confused with that page after getting this message. I was just planning to add a Troubleshooting area to that topic to explain some warnings you might get and what to do. There's also a warning from EF projects that are redirected to that same topic.

However, this simplification makes the warning even more cryptic in my opinion.

Copy link
Contributor Author

@nguerrera nguerrera Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to take this change, then?

Copy link
Member

@dsplaisted dsplaisted Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should either add back a sentence along the lines of "You can define the SDK version via a global.json file in the current project.", or create a more specific page for https://aka.ms/dotnet-core-preview to point to.

Copy link
Contributor

@mairaw mairaw Jun 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That page is getting expanded dotnet/docs#4704

Copy link
Member

@dsplaisted dsplaisted Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That page is getting expanded dotnet/docs#4704

Given those updates to the target of the link, I think the message in this PR is OK.

Copy link

@KathleenDollard KathleenDollard Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with @dsplaisted 's suggested resolution here.

<comment>{StrBegin="NETSDK1057: "}</comment>
</data>
<data name="InvalidItemSpecToUse" xml:space="preserve">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: Pracujete se sadou .NET Core SDK verze Preview. Verzi sady SDK můžete definovat prostřednictvím souboru global.json v aktuálním projektu. Další informace najdete na adrese https://go.microsoft.com/fwlink/?linkid=869452.</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: Pracujete se sadou .NET Core SDK verze Preview. Verzi sady SDK můžete definovat prostřednictvím souboru global.json v aktuálním projektu. Další informace najdete na adrese https://go.microsoft.com/fwlink/?linkid=869452.</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: Sie arbeiten mit einer Vorschauversion des .NET Core SDK. Sie können die SDK-Version über eine Datei "global.json" im aktuellen Projekt definieren. Weitere Informationen finden Sie unter https://go.microsoft.com/fwlink/?linkid=869452.</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: Sie arbeiten mit einer Vorschauversion des .NET Core SDK. Sie können die SDK-Version über eine Datei "global.json" im aktuellen Projekt definieren. Weitere Informationen finden Sie unter https://go.microsoft.com/fwlink/?linkid=869452.</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: Está trabajando con una versión preliminar del SDK de .NET Core. Puede definir la versión del SDK mediante un archivo .json global en el proyecto actual. Más información en https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: Está trabajando con una versión preliminar del SDK de .NET Core. Puede definir la versión del SDK mediante un archivo .json global en el proyecto actual. Más información en https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: Vous utilisez une préversion du kit SDK .NET Core. Vous pouvez définir la version du kit SDK via un fichier global.json dans le projet actif. Pour plus d'informations, consultez https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: Vous utilisez une préversion du kit SDK .NET Core. Vous pouvez définir la version du kit SDK via un fichier global.json dans le projet actif. Pour plus d'informations, consultez https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: si sta usando una versione in anteprima di .NET Core SDK. È possibile definire la versione dell'SDK tramite un file global.json nel progetto corrente. Per altre informazioni, vedere https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: si sta usando una versione in anteprima di .NET Core SDK. È possibile definire la versione dell'SDK tramite un file global.json nel progetto corrente. Per altre informazioni, vedere https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: .NET Core SDK のプレビュー バージョンで作業をしています。現在のプロジェクトの global.json ファイルによって SDK バージョンを定義できます。詳細については、https://go.microsoft.com/fwlink/?linkid=869452 をご覧ください</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: .NET Core SDK のプレビュー バージョンで作業をしています。現在のプロジェクトの global.json ファイルによって SDK バージョンを定義できます。詳細については、https://go.microsoft.com/fwlink/?linkid=869452 をご覧ください</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: .NET Core SDK의 미리 보기 버전으로 작업하고 있습니다. 현재 프로젝트의 global.json 파일을 통해 SDK 버전을 정의할 수 있습니다. 자세한 내용은 https://go.microsoft.com/fwlink/?linkid=869452를 참조하세요.</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: .NET Core SDK의 미리 보기 버전으로 작업하고 있습니다. 현재 프로젝트의 global.json 파일을 통해 SDK 버전을 정의할 수 있습니다. 자세한 내용은 https://go.microsoft.com/fwlink/?linkid=869452를 참조하세요.</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: Korzystasz z zestawu .NET Core SDK w wersji zapoznawczej. Możesz zdefiniować wersję zestawu SDK za pomocą pliku global.json w bieżącym projekcie. Więcej informacji można znaleźć na stronie https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: Korzystasz z zestawu .NET Core SDK w wersji zapoznawczej. Możesz zdefiniować wersję zestawu SDK za pomocą pliku global.json w bieżącym projekcie. Więcej informacji można znaleźć na stronie https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: Você está trabalhando com uma versão prévia do SDK do .NET Core. É possível definir a versão do SDK usando um arquivo global.json no projeto atual. Mais informações em https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: Você está trabalhando com uma versão prévia do SDK do .NET Core. É possível definir a versão do SDK usando um arquivo global.json no projeto atual. Mais informações em https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: вы работаете с предварительной версией пакета SDK для .NET Core. Установить версию SDK можно в файле global.json текущего проекта. Дополнительные сведения: https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: вы работаете с предварительной версией пакета SDK для .NET Core. Установить версию SDK можно в файле global.json текущего проекта. Дополнительные сведения: https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: .NET Core SDK’nın önizleme sürümüyle çalışıyorsunuz. SDK sürümünü geçerli projedeki bir global.json dosyası aracılığıyla tanımlayabilirsiniz. Daha fazla bilgi edinmek için bkz. https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: .NET Core SDK’nın önizleme sürümüyle çalışıyorsunuz. SDK sürümünü geçerli projedeki bir global.json dosyası aracılığıyla tanımlayabilirsiniz. Daha fazla bilgi edinmek için bkz. https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: 你正在使用 .NET Core SDK 的预览版。可通过当前项目中的 global.json 文件来定义 SDK 版本。详细信息请访问 https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: 你正在使用 .NET Core SDK 的预览版。可通过当前项目中的 global.json 文件来定义 SDK 版本。详细信息请访问 https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@
<note>{StrBegin="NETSDK1056: "}</note>
</trans-unit>
<trans-unit id="UsingPreviewSdkWarning">
<source>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</source>
<target state="translated">NETSDK1057: 您目前正使用 .NET Core SDK 的預覽版本。您可透過目前專案中的 global.json 檔案，定義 SDK 版本。如需更多項目，請前往 https://go.microsoft.com/fwlink/?linkid=869452</target>
<source>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</source>
<target state="needs-review-translation">NETSDK1057: 您目前正使用 .NET Core SDK 的預覽版本。您可透過目前專案中的 global.json 檔案，定義 SDK 版本。如需更多項目，請前往 https://go.microsoft.com/fwlink/?linkid=869452</target>
<note>{StrBegin="NETSDK1057: "}</note>
</trans-unit>
<trans-unit id="InvalidItemSpecToUse">
Expand Down