Skip to content

Conversation

@nguerrera
Copy link
Contributor

@nguerrera nguerrera commented May 29, 2018

Replaces #2198

@nguerrera
Copy link
Contributor Author

nguerrera commented May 29, 2018

cc @KathleenDollard @livarcocc @richlander Moved rich's commit onto 2.1.4xx, resolved merge conflict with error codes, and updated XLF.

@nguerrera nguerrera requested a review from a team May 29, 2018 23:31
</data>
<data name="UsingPreviewSdkWarning" xml:space="preserve">
<value>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</value>
<value>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richlander The aka.ms link here redirects to https://docs.microsoft.com/en-us/dotnet/core/tools/global-json, which is just a generic global.json reference. Is that the intent or will there be a different page more specific to .NET Core previews?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mairaw

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft's style guide asks for contractions (https://docs.microsoft.com/en-us/style-guide/word-choice/use-contractions):
You are -> You're

@dsplaisted I wasn't aware of that link going to our topic until a customer got confused with that page after getting this message. I was just planning to add a Troubleshooting area to that topic to explain some warnings you might get and what to do. There's also a warning from EF projects that are redirected to that same topic.

However, this simplification makes the warning even more cryptic in my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to take this change, then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should either add back a sentence along the lines of "You can define the SDK version via a global.json file in the current project.", or create a more specific page for https://aka.ms/dotnet-core-preview to point to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That page is getting expanded dotnet/docs#4704

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That page is getting expanded dotnet/docs#4704

Given those updates to the target of the link, I think the message in this PR is OK.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with @dsplaisted 's suggested resolution here.

@livarcocc livarcocc added this to the 2.1.4xx milestone May 31, 2018
@nguerrera nguerrera modified the milestones: 2.1.4xx, 2.2.1xx Jul 9, 2018
@nguerrera nguerrera changed the base branch from release/2.1.4xx to release/2.2.1xx July 9, 2018 17:26
@nguerrera nguerrera merged commit 8ccd838 into dotnet:release/2.2.1xx Jul 9, 2018
@nguerrera nguerrera deleted the preview2 branch July 9, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants