-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Simplify preview warning #2286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify preview warning #2286
Conversation
|
cc @KathleenDollard @livarcocc @richlander Moved rich's commit onto 2.1.4xx, resolved merge conflict with error codes, and updated XLF. |
| </data> | ||
| <data name="UsingPreviewSdkWarning" xml:space="preserve"> | ||
| <value>NETSDK1057: You are working with a preview version of the .NET Core SDK. You can define the SDK version via a global.json file in the current project. More at https://go.microsoft.com/fwlink/?linkid=869452</value> | ||
| <value>NETSDK1057: You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richlander The aka.ms link here redirects to https://docs.microsoft.com/en-us/dotnet/core/tools/global-json, which is just a generic global.json reference. Is that the intent or will there be a different page more specific to .NET Core previews?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mairaw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Microsoft's style guide asks for contractions (https://docs.microsoft.com/en-us/style-guide/word-choice/use-contractions):
You are -> You're
@dsplaisted I wasn't aware of that link going to our topic until a customer got confused with that page after getting this message. I was just planning to add a Troubleshooting area to that topic to explain some warnings you might get and what to do. There's also a warning from EF projects that are redirected to that same topic.
However, this simplification makes the warning even more cryptic in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want to take this change, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either add back a sentence along the lines of "You can define the SDK version via a global.json file in the current project.", or create a more specific page for https://aka.ms/dotnet-core-preview to point to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That page is getting expanded dotnet/docs#4704
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That page is getting expanded dotnet/docs#4704
Given those updates to the target of the link, I think the message in this PR is OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with @dsplaisted 's suggested resolution here.
Replaces #2198