Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.1xx] Update dependencies from dotnet/runtime #27210

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 16, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 8af13382-1cd2-4402-139a-08da7ef5fa55
  • Build: 20220821.2
  • Date Produced: August 21, 2022 12:19:23 PM UTC
  • Commit: bc7a715b1b1cdb63bf62b23c7f7ca0dc16cb9420
  • Branch: refs/heads/release/7.0

dsplaisted and others added 8 commits July 21, 2022 20:56
…0816.3

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22416.3
…816.3

Microsoft.SourceBuild.Intermediate.fsharp , Microsoft.FSharp.Compiler
 From Version 6.0.6-beta.22414.2 -> To Version 6.0.6-beta.22416.3
@lewing
Copy link
Member

lewing commented Aug 17, 2022

See discussion at #27149

…815.4

Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22415.1 -> To Version 7.0.100-1.22415.4
@lewing
Copy link
Member

lewing commented Aug 17, 2022

waiting on dotnet/runtime#74042

[main] Update dependencies from dotnet/linker


 - Workaround for the floating version with a specific one

 - Merge branch 'main' of https://github.com/dotnet/sdk into darc-main-6d2336f7-8e45-4040-a5ee-f40e1cbcdd1b

 - updating the floating version to a fixed one on main test as well
dotnet-maestro bot and others added 5 commits August 17, 2022 05:35
…816.8

Microsoft.SourceBuild.Intermediate.fsharp , Microsoft.FSharp.Compiler
 From Version 6.0.6-beta.22414.2 -> To Version 6.0.6-beta.22416.8
…46-ba45-4e01-b78b-e4981616eb0a

[release/7.0.1xx-rc1] Update dependencies from dotnet/linker
…nto darc-release/7.0.1xx-rc1-8962846c-e60a-481b-ad2a-8d078b6c8902
…0816.2 (#27204)

[release/7.0.1xx-rc1] Update dependencies from dotnet/msbuild
…6c-e60a-481b-ad2a-8d078b6c8902

[release/7.0.1xx-rc1] Update dependencies from dotnet/fsharp
@jeffschwMSFT
Copy link
Member

dotnet/runtime#74048

dotnet-maestro bot and others added 2 commits August 17, 2022 16:09
…6.4.0.47

NuGet.Build.Tasks
 From Version 6.4.0-preview.1.44 -> To Version 6.4.0-preview.1.47
…6a-4477-4b8d-b971-87b2e6b695f0

[release/7.0.1xx-rc1] Update dependencies from nuget/nuget.client
@sbomer
Copy link
Member

sbomer commented Aug 17, 2022

runtime -> sdk dependency flow is currently set up for the 7.0 -> 7.0.1xx branches, but disabled for 7.0-rc1 -> 7.0.1xx-rc1. I don't think we will see this PR get the change until dotnet/runtime#74045 goes through.

@carlossanlop which SDK branch should we be tracking for RC1? Would it make sense to enable the runtime 7.0-rc1 -> sdk 7.0.1xx-rc1 subscription, instead of waiting for the change to go from runtime 7.0-rc1 -> runtime 7.0 -> SDK 7.0.1xx?

@ViktorHofer
Copy link
Member

@carlossanlop which SDK branch should we be tracking for RC1? Would it make sense to enable the runtime 7.0-rc1 -> sdk 7.0.1xx-rc1 subscription, instead of waiting for the change to go from runtime 7.0-rc1 -> runtime 7.0 -> SDK 7.0.1xx?

cc @mmitche

@mmitche
Copy link
Member

mmitche commented Aug 17, 2022

@carlossanlop which SDK branch should we be tracking for RC1? Would it make sense to enable the runtime 7.0-rc1 -> sdk 7.0.1xx-rc1 subscription, instead of waiting for the change to go from runtime 7.0-rc1 -> runtime 7.0 -> SDK 7.0.1xx?

cc @mmitche

RC 1 flow is internal and we can't have parallel public flow, so the public subscription should not be enabled.

…0817.9

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22417.9
@jeffschwMSFT
Copy link
Member

This has failed with the same error.

error NETSDK1183: Unable to optimize assemblies for Ahead of time compilation: a valid runtime package was not found. Either set the PublishAot property to false, or use a supported runtime identifier when publishing. When targeting .NET 7 or higher, make sure to restore packages with the PublishAot property set to true. [C:\h\w\A6E40912\t\dotnetSdkTests\rkhmz2i4.33m\AoT_Publish_W---DA56BF44\blazorwasm\blazorwasm.csproj]

If the latest dependency flow has the fix, we need to investigate.

cc @sbomer @LakshanF @MichalStrehovsky

@MichalStrehovsky
Copy link
Member

If the latest dependency flow has the fix, we need to investigate.

I don't think this has is. This is for refs/heads/release/7.0. We don't have the fix in the 7.0 branch yet. Just 7.0-RC1.

The RC1 -> 7.0 merge is sitting in dotnet/runtime#74045.

…0820.10

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22418.9 -> To Version 7.0.0-rc.1.22420.10
…0820.14

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22418.9 -> To Version 7.0.0-rc.1.22420.14
…0820.18

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22418.9 -> To Version 7.0.0-rc.1.22420.18
…0821.2

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22421.2
@jeffschwMSFT
Copy link
Member

@radical @lewing the wasm tests are failing due to the baseline:
Microsoft.NET.Sdk.BlazorWebAssembly.Tests.BlazorWasmStaticWebAssetsIntegrationTest.StaticWebAssets_Publish_DoesNotIncludeXmlDocumentationFiles_AsAssets [FAIL]
Expected root to be a collection with 235 item(s)

…0821.6

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22418.9 -> To Version 7.0.0-rc.1.22421.6
@danmoseley
Copy link
Member

The WASM publish baselines seem to be the only failing tests now.

dotnet-maestro bot and others added 2 commits August 22, 2022 01:40
…0821.12

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22418.9 -> To Version 7.0.0-rc.1.22421.12
@lewing
Copy link
Member

lewing commented Aug 22, 2022

see #27307 (comment)

dsplaisted and others added 4 commits August 22, 2022 00:17
Update handling of SelfContained and RuntimeIdentifier properties when specified on the command line
…d7-9a64-49c6-84b3-2dbc8bcfb08b

[release/7.0.1xx-rc1] Update dependencies from dotnet/runtime
@dsplaisted
Copy link
Member

Looks like we probably need to merge or cherry-pick the RC1 changes from #27307

@danmoseley
Copy link
Member

I merged RC1 from f4c17b4 .. now there are more conflicts

@danmoseley
Copy link
Member

@dotnet/domestic-cat any clue on this on Windows_NT_TemplateEngine Build_Release

2022-08-22T20:10:19.4039870Z   Successfully created package 'D:\a\_work\1\s\artifacts\packages\Release\NonShipping\Microsoft.TemplateEngine.Cli.UnitTests.7.0.100-ci.nupkg'.
2022-08-22T20:10:24.0738519Z D:\a\_work\1\s\.dotnet\sdk\7.0.100-preview.5.22307.18\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(248,5): error MSB3030: Could not copy the file "D:\a\_work\1\s\src\Assets\TestPackages\dotnet-hello\v2\dotnet-hello\obj\26f3c826-fe26-4577-b11b-35fe912fe9e8.tmp" because it was not found. [D:\a\_work\1\s\src\Tests\dotnet.Tests\dotnet.Tests.csproj]
2022-08-22T20:10:24.0885915Z ##[error].dotnet\sdk\7.0.100-preview.5.22307.18\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Publish.targets(248,5): error MSB3030: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy the file "D:\a\_work\1\s\src\Assets\TestPackages\dotnet-hello\v2\dotnet-hello\obj\26f3c826-fe26-4577-b11b-35fe912fe9e8.tmp" because it was not found.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 22, 2022

@dsplaisted do you know anything about the test failure Dan mentioned above?

@danmoseley
Copy link
Member

That seems to be the only test failure blocking merge.

@danmoseley
Copy link
Member

I'm rerunning just that

@marcpopMSFT marcpopMSFT merged commit 4bd607d into release/7.0.1xx Aug 23, 2022
@marcpopMSFT marcpopMSFT deleted the darc-release/7.0.1xx-14a8c2b8-08ac-4b18-bcc9-82984b69d2c5 branch August 23, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.