Read PackageDefinitions and PackageDependencies from the cache assets file instead of ResolvePackageDependencies #28263
Conversation
Removing all the conditions that depend on EmitLegacyAssetsFileItems since there is case when this variable is false.
| if (messages.Count() == 0) | ||
| { | ||
| return string.Empty; | ||
| } | ||
|
|
||
| return messages.Max(log => log.Level).ToString(); |
There was a problem hiding this comment.
This is double-enumerating messages. Use a foreach here to ensure items are only enumerated once.
|
@ocallesp I started diving into reviewing this, which led me to investigate in more detail how some of this data is used. Based on that I'd like to try changing how we handle this. We are trying to improve the perf of the design-time builds. I believe the design-time build does not depend directly on the The So instead of generating If we do this, @drewnoakes Does this sound like it would work? Is it correct that the project system only depends on the items returned by the |
|
Also, we'd like to target this feature for |
|
@dsplaisted that's my understanding, yes. Sounds like a nice optimisation for design-time builds. |
|
The suggested approach is different from the original one. This pr #28405 implements the new approach. |
Fixes #27738
We want to avoid reading the assets file because it is a large file, which can cause performance degradation in design-time builds for large projects when executing
ResolvePackageDependencies.To improve this, the assets cache file in
ResolvePackageAssetswill now keep track ofPackageDefinitionsandPackageDependencies.The change:
Output
PackageDefinitionsandPackageDependenciesitems fromResolvePackageAssets, and modified the targets so thatResolvePackageDependenciesis only called whenEmitLegacyAssetsFileItemsis true.All the code related to
EmitLegacyAssetsFileItemsinResolvePackageDependencieswas removed since there is case for when the value is false.Unit-tests were modified to remove
EmitLegacyAssetsFileItemsin ResolvePackageDependencies.