Add PackageDependenciesDesignTime to cache assets file

[ocallesp]

Fixes #27738

Implements reading the PackageDefinitions and PackageDependencies items in ResolvePackageAssets, so that ResolvePackageDependencies doesn't need to be called at all unless EmitLegacyAssetsFileItems is true. This improve incremental build perf and also significantly improve the design time build perf (23%) for this large solution scenario by saving to the cache file the same items generated from PreprocessPackageDependenciesDesignTime.

---

Note:
This implementation was taken from PreprocessPackageDependenciesDesignTime.ExecuteCore

[dsplaisted]

See comments for ways we should be able to eliminate a bunch of the code here and process less data.

[dsplaisted]

This is looking good, thanks.

Have you made any progress with @drewnoakes on running the project system tests with these changes?

Also do you have any perf testing results? It would be great to be able to present those (or a demo) at the next team showcase.

[drewnoakes]

The test should delete both of these files when it completes, to avoid polluting the temp dir.

The same is true for other tests below.

[ocallesp]

@marcin-krystianc I see that the repository https://github.com/marcin-krystianc/TestSolutions/tree/master/LargeAppWithPrivatePackagesCentralisedNGBVRemoved does not contain any readme file nor a license.

We would like to know if we are allowed to share this with folks.

[marcin-krystianc]

@marcin-krystianc I see that the repository https://github.com/marcin-krystianc/TestSolutions/tree/master/LargeAppWithPrivatePackagesCentralisedNGBVRemoved does not contain any readme file nor a license.

We would like to know if we are allowed to share this with folks.

Hi @ocallesp, I'll add some readme and license information, but of course it is ok to share it with others.

[ocallesp]

@marcin-krystianc I appreciate your willingness to share your repository with others.