Support ".Ref" targeting packs and .NET Standard 2.1 #2919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
force-pushed
the
use-targeting-pack
branch
2 times, most recently
from
b5a3d10 to
781ce9a
Compare
dsplaisted
force-pushed
the
use-targeting-pack
branch
from
781ce9a to
305cc4d
Compare
dsplaisted
force-pushed
the
use-targeting-pack
branch
2 times, most recently
from
66d1a7f to
f5f53a7
Compare
dsplaisted
force-pushed
the
use-targeting-pack
branch
from
f5f53a7 to
9843b2f
Compare
dsplaisted
changed the title
nguerrera
reviewed
Feb 13, 2019
src/Tasks/Microsoft.NET.Build.Tasks/ResolveTargetingPackAssets.cs
Outdated
Show resolved
Hide resolved
nguerrera
reviewed
Feb 13, 2019
src/Tasks/Microsoft.NET.Build.Tasks/ResolveFrameworkReferences.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.props
Show resolved
Hide resolved
Contributor
|
I think #2839 will start to be a real issue with the .Ref targeting pack as there won't be dependencies downloaded. |
nguerrera
reviewed
Feb 18, 2019
src/Tasks/Microsoft.NET.Build.Tasks/ResolveFrameworkReferences.cs
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/ResolveFrameworkReferences.cs
Outdated
Show resolved
Hide resolved
dsplaisted
force-pushed
the
use-targeting-pack
branch
from
e587d3c to
ed3755e
Compare
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
….1 (dotnet#2919) - Microsoft.NET.Sdk - 3.0.100-rc2.19467.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the ".Ref" targeting packs for .NET Core and ASP.NET Core, as well as .NET Standard 2.1.
The core-sdk repo needs to be updated to include these in the
KnownFrameworkReferenceitems in the bundled versions file. However, we need to check this logic into the SDK (and flow it into core-sdk) first, because we changed the layout for the .NET Core targeting pack and things would fail if we bundled a version of the targeting pack that the SDK code couldn't understand. (Note that the layout in this PR isn't necessarily final either.)There's temporary logic in this PR to update the
KnownFrameworkReferenceitems to refer to the new targeting packs for testing purposes. Once we do the round trip through core-sdk, we can remove that logic.Also note that this PR currently adds a
KnownFrameworkReferencefor NETStandard.Library, but that is checked in to core-sdk already (since it's for a new TargetFramework), so once we have a build from core-sdk with the changes from dotnet/installer#477, I will update this PR to remove that workaround.