Changes to emit a failure message when enabling ReadyToRun in unsupported scenarios #3123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@nguerrera PTAL |
fadimounir
commented
Apr 12, 2019
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets
Outdated
Show resolved
Hide resolved
dsplaisted
approved these changes
Apr 15, 2019
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets
Outdated
Show resolved
Hide resolved
Member
|
Can you add a test covering this? |
nguerrera
reviewed
Apr 15, 2019
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Publish.targets
Outdated
Show resolved
Hide resolved
Author
swaroop-sridhar
approved these changes
Apr 16, 2019
| </PropertyGroup> | ||
|
|
||
| <!-- TODO: Temp error to limit R2R compilation to self-contained mode only. Delete this when fixing #3109 and #3110 --> | ||
| <NETSdkError Condition="'$(SelfContained)' != 'true'" ResourceName="ReadyToRunTargetNotSuppotedError" /> |
Contributor
There was a problem hiding this comment.
Should this check be upfront (say in prepare for publish) before we do any work for R2R compilation?
Not a significant issue, since this is only an interim check.
Author
There was a problem hiding this comment.
It is upfront. It runs before the PrepareForReadyToRunCompilation task, which runs before any compilation
nguerrera
approved these changes
Apr 17, 2019
wli3
pushed a commit
that referenced
this pull request
Feb 7, 2020
….5 (#3123) - Microsoft.DotNet.Cli.Runtime - 5.0.100-alpha1.19506.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsupported scenarios are: