Skip to content

Changes to emit a failure message when enabling ReadyToRun in unsupported scenarios #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nguerrera merged 2 commits into from
Apr 17, 2019
Merged

Changes to emit a failure message when enabling ReadyToRun in unsupported scenarios #3123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1803b92
Changes to emit a failure message when enabling ReadyToRun in unsuppo…
Apr 12, 2019
5649aa9
CR feedback: change error message to something more clear, and add te…
Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ The following are names of parameters or literal values and should not be transl
<comment>{StrBegin="NETSDK1094: "}</comment>
</data>
<data name="ReadyToRunTargetNotSuppotedError" xml:space="preserve">
<value>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</value>
<value>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</value>
<comment>{StrBegin="NETSDK1095: "}</comment>
</data>
<data name="ReadyToRunCompilationFailed" xml:space="preserve">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
4 changes: 2 additions & 2 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,8 @@ The following are names of parameters or literal values and should not be transl
<note>{StrBegin="NETSDK1094: "}</note>
</trans-unit>
<trans-unit id="ReadyToRunTargetNotSuppotedError">
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Either set the ReadyToRun property to false, or use a supported runtime identifier when publishing.</target>
<source>NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</source>
<target state="new">NETSDK1095: Optimizing assemblies for performance is not supported for the selected target platform or architecture. Please verify you are publishing a self-contained application using a supported runtime identifier, or set the ReadyToRun property to false.</target>
<note>{StrBegin="NETSDK1095: "}</note>
</trans-unit>
<trans-unit id="RuntimeIdentifierNotRecognized">
Expand Down
Loading