Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small build issues #3340

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Fix small build issues #3340

merged 3 commits into from
Jun 19, 2019

Conversation

nguerrera
Copy link
Contributor

Three separate small issues in three commits:

  1. Fix incremental build in VS when only target files change. This had been driving me crazy causing tests to run without my targets changes. Fixed the other two while I was playing around nearby.

  2. Remove outdated workaround

  3. Auto-bump version of task assemblies. Fix Assembly version stopped being bumped with every build in 2.1.300+ #2953. Follows Arcade recommendation.

@nguerrera nguerrera requested review from dsplaisted, peterhuene and a team June 18, 2019 20:47
@nguerrera nguerrera merged commit 7aa2004 into dotnet:master Jun 19, 2019
@nguerrera nguerrera deleted the build-issues branch June 19, 2019 04:43
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
…0191028.1 (dotnet#3340)

- Microsoft.Build.Localization - 16.4.0-preview-19528-01
- Microsoft.Build - 16.4.0-preview-19528-01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly version stopped being bumped with every build in 2.1.300+
3 participants