-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .NET Core SDK Url in build on Windows instructions #36939
Conversation
@dotnet/roslyn-infrastructure @nguerrera This is an ongoing problem for external contributors. Visual Studio failed with unusable messages, left me unable to build Roslyn, and there were no links or documentation to fix it. I had to manually craft a download URL using the output from Restore.cmd. We need a solution earlier rather than later. |
@sharwell There are some changes coming in that should help:
|
Looking a little closer, though, at this specific case, I would not have expected a failure here.
Was the error an issue with a task having bad parameters or failing to load? If so, I think it was the issue where we stopped bumping our assembly version between builds due to an infrastructure change. That was recently fixed as well: dotnet/sdk#3340. |
@nguerrera Is this (#36840) the type of error that you expect would be fixed by dotnet/sdk#3340?
|
Yes, exactly! |
dotnet-maestro was inconsiderate and updated the dotnet version in global.json without updating the url in Building on Windows documentation.