-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mono Stage 2 Leg to VMR SB #41606
Conversation
I'd like to have dotnet/source-build#4465 triaged before merging this. |
Makes sense. I'll convert this to a draft for now. |
@ellahathaway - can you confirm the fsharp fix has flown into the SDK? If not we should hold off on merging. |
Note that CI is currently on the floor. Will be fixed with #41621 |
Sure! Just queued https://dev.azure.com/dnceng/internal/_build/results?buildId=2478624&view=results. If it's green I'll merge. |
My test run is encountering the Stage 2 errors described in dotnet/source-build#4477 so I cannot validate if the previous fsharp error was fixed. |
I will try to resolve them on Monday. |
Thanks Viktor! |
Note that stage2 is still broken until #41826 is merged. |
Sounds good. I moved the associated issue to blocked in the meantime. |
This is finally unblocked :) |
Wonderful! I'll queue a run of the full pipeline to check the stage 2 build. |
New pipeline run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2490555&view=results (internal Microsoft link) |
More unrelated failures: dotnet/source-build#4494 |
Testing again now that stage 2 has been fixed: https://dev.azure.com/dnceng/internal/_build/results?buildId=2497104&view=logs&s=9b073b6c-199e-5782-2adb-83c30ea48e21 Edit: Hit dotnet/source-build#4513 so I'm retrying the stage 2 build again. Edit # 2: It passed on retry! Merging the PR :) |
Closes dotnet/source-build#4465
This PR adds a Mono Stage 2 Leg to dotnet-source-build. Here is an example run of the pipeline with the proposed changes (internal Microsoft link).