Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mono Stage 2 Leg to VMR SB #41606

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Jun 14, 2024

Closes dotnet/source-build#4465

This PR adds a Mono Stage 2 Leg to dotnet-source-build. Here is an example run of the pipeline with the proposed changes (internal Microsoft link).

@ellahathaway ellahathaway requested review from a team as code owners June 14, 2024 18:50
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jun 14, 2024
@mthalman
Copy link
Member

I'd like to have dotnet/source-build#4465 triaged before merging this.

@ellahathaway
Copy link
Member Author

I'd like to have dotnet/source-build#4465 triaged before merging this.

Makes sense. I'll convert this to a draft for now.

@ellahathaway ellahathaway marked this pull request as draft June 14, 2024 20:05
@ellahathaway ellahathaway marked this pull request as ready for review June 20, 2024 18:05
@MichaelSimons
Copy link
Member

@ellahathaway - can you confirm the fsharp fix has flown into the SDK? If not we should hold off on merging.

@ViktorHofer
Copy link
Member

Note that CI is currently on the floor. Will be fixed with #41621

@ellahathaway
Copy link
Member Author

@ellahathaway - can you confirm the fsharp fix has flown into the SDK? If not we should hold off on merging.

Sure! Just queued https://dev.azure.com/dnceng/internal/_build/results?buildId=2478624&view=results. If it's green I'll merge.

@ellahathaway
Copy link
Member Author

ellahathaway commented Jun 21, 2024

My test run is encountering the Stage 2 errors described in dotnet/source-build#4477 so I cannot validate if the previous fsharp error was fixed.

@ViktorHofer
Copy link
Member

I will try to resolve them on Monday.

@ellahathaway
Copy link
Member Author

I will try to resolve them on Monday.

Thanks Viktor!

@ViktorHofer
Copy link
Member

Note that stage2 is still broken until #41826 is merged.

@ellahathaway
Copy link
Member Author

Note that stage2 is still broken until #41826 is merged.

Sounds good. I moved the associated issue to blocked in the meantime.

@ViktorHofer
Copy link
Member

This is finally unblocked :)

@ellahathaway
Copy link
Member Author

This is finally unblocked :)

Wonderful! I'll queue a run of the full pipeline to check the stage 2 build.

@ellahathaway
Copy link
Member Author

New pipeline run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2490555&view=results (internal Microsoft link)

@ellahathaway
Copy link
Member Author

More unrelated failures: dotnet/source-build#4494

@ellahathaway
Copy link
Member Author

ellahathaway commented Jul 17, 2024

Testing again now that stage 2 has been fixed: https://dev.azure.com/dnceng/internal/_build/results?buildId=2497104&view=logs&s=9b073b6c-199e-5782-2adb-83c30ea48e21

Edit: Hit dotnet/source-build#4513 so I'm retrying the stage 2 build again.

Edit # 2: It passed on retry! Merging the PR :)

@ellahathaway ellahathaway enabled auto-merge (squash) July 17, 2024 23:16
@ellahathaway ellahathaway merged commit 0344f9c into dotnet:main Jul 18, 2024
37 checks passed
@ellahathaway ellahathaway deleted the mono-stage2 branch July 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI support for Mono stage 2 build
4 participants