Linux: Installing/Updating packages with uppercase versions

[edvilme]

Addresses #39105 #24419 #41844, NuGet/Home#13844, etc

When attempting to install or update a tool on Linux, the system looks for the file with the version as is, instead of lowercasing it. Packages are ideally stored with lowercase versions on them according to the NuGet team, so the system fails to find them.

Instead, versions are lowercased and the VersionFolderPathResolver API is used for path operations to be compliant with changes from the NuGet codebase.

[nkolev92]

I think having an E2E or at least some unit tests for the installation path generated would help long term.

[nagilson]

There's still some pending feedback I'd like to resolve / hear from others on, but great job on your first PR in the SDK! 😊 This was a lot more challenging than expected which is our fault so I do apologize for that. I think you did a great job independently investigating and contacting the nuget team so great work 👏

[nagilson]

On ToolRestoreCommand line 157, I would lowercase the package.Version going into the Tool Resolver cache. I would also do this in the localToolsResolverCache line 26, 149. I think its possible that data could come to bite us later if we access it somewhere without lowercasing the version. But part of this is just because Im not knowledgeable about this codebase so I am being pretty precautious; doing this may cause other problems too.

Also going to ping @dsplaisted to see his thoughts.

[nagilson]

ToolRestoreCommand.PackageHasBeenRestored Loads the Cache of tool restore commands previously executed and then the locations of those tools that were previously restored -> TryGetMatchingRestoredCommand -> LocalTolsResolverCache Save uses RestoredCommand.Executable to cache the location of the package, it includes Version as well which is not lowercased but that Version is not used to generate a path so it's ok, also I think we want to store the true version of the package and not the lowercased one for nuget's directory purposes
-> ToolRestoreCommand.InstallPackages has IToolPackage with Command with Executable -> ToolPackageDownloader.InstallPackage -> Uses Nuget Version in the Version but toolReturnPackageDirectory for the directory which happens at ToolPackageStoreAndQuery from GetPackageDirectory which already lowercased the version.................

TLDR: This is the correct approach and we dont need to lowercase this version I think 😵

[dsplaisted]

LGTM, thanks!

[edvilme]

Hello @nagilson @dsplaisted,
Please let me know if there is anything else on my end for this PR, thx! :D

[nagilson]

One thing I thought was a side effect of this change at first is

that dotnet tool list will only show a lowercase version. This doesnt matter in terms of a breaking change on Linux because even in 7.0 it didnt quite work properly.

However on Windows it did, but it looks like even on Windows it was lowercased in the past, so that's not a concern.

[nagilson]

Fantastic work, this was much harder than anticipated. You did a great job digging through the code, thank you. I would not expect a typical new grad to be able to do that. Let's get this merged!

[edvilme]

Fantastic work, this was much harder than anticipated. You did a great job digging through the code, thank you. I would not expect a typical new grad to be able to do that. Let's get this merged!

Thanks! It was very interesting and useful to get to know the tooling a bit better :)