Skip to content

Conversation

@kasperk81
Copy link
Contributor

@kasperk81 kasperk81 commented Dec 27, 2024

InternalAbstractions netstandard support is only needed by Microsoft.NET.TestFramework.csproj. for that CreateTempSubdirectory is using p/invoke for all dependents

making InternalAbstractions multi-framework same as Microsoft.NET.TestFramework.csproj to simplify CreateTempSubdirectory and deleting unused methods

#45631

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Dec 27, 2024
@kasperk81
Copy link
Contributor Author

@marcpopMSFT @baronfel can we backport it to 9.0.2xx?

@marcpopMSFT marcpopMSFT requested a review from nagilson January 8, 2025 23:25
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on #45631 (comment)

@kasperk81
Copy link
Contributor Author

updated. it guarantees the desired file mode is set on unix without pinvoke

@nagilson nagilson self-requested a review January 14, 2025 18:50
@nagilson
Copy link
Member

Thank you for this fix and your patience in the review process 👏

@nagilson
Copy link
Member

Failed Microsoft.DotNet.Tests.JoinVerticalsTests.JoinVerticalsCheckAllAmbiguitiesTest [51 ms] Error Message: Assert.DoesNotContain() Failure: Filter matched in collection

System.InvalidOperationException : Failed to execute /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/dotnet new globaljson --sdk-version 10.0.100-preview.3.25169.1

@dotnet/source-build May you PTAL at these failures?

@ellahathaway
Copy link
Member

Failed Microsoft.DotNet.Tests.JoinVerticalsTests.JoinVerticalsCheckAllAmbiguitiesTest [51 ms] Error Message: Assert.DoesNotContain() Failure: Filter matched in collection

System.InvalidOperationException : Failed to execute /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/dotnet new globaljson --sdk-version 10.0.100-preview.3.25169.1

@dotnet/source-build May you PTAL at these failures?

See dotnet/source-build#4952

@kasperk81
Copy link
Contributor Author

thanks for syncing with main @nagilson

@nagilson nagilson merged commit b01c655 into dotnet:main Mar 26, 2025
39 checks passed
@kasperk81
Copy link
Contributor Author

@nagilson #45633 related pr replacing direct libc calls leftover from old days. ptal

@kasperk81 kasperk81 deleted the pathutil branch March 27, 2025 07:50
@nagilson
Copy link
Member

@kasperk81 I believe that PR links to this one, your activity is private, and I didnt see any other SDK PRS from you, which one did you mean?

@kasperk81
Copy link
Contributor Author

oh sorry i meant #45637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants