-
Notifications
You must be signed in to change notification settings - Fork 1.2k
simplify CreateTempSubdirectory #45633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@marcpopMSFT @baronfel can we backport it to 9.0.2xx? |
nagilson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment on #45631 (comment)
|
updated. it guarantees the desired file mode is set on unix without pinvoke |
|
Thank you for this fix and your patience in the review process 👏 |
|
@dotnet/source-build May you PTAL at these failures? |
|
|
thanks for syncing with main @nagilson |
|
@kasperk81 I believe that PR links to this one, your activity is private, and I didnt see any other SDK PRS from you, which one did you mean? |
|
oh sorry i meant #45637 |
InternalAbstractionsnetstandard support is only needed byMicrosoft.NET.TestFramework.csproj. for thatCreateTempSubdirectoryis using p/invoke for all dependentsmaking
InternalAbstractionsmulti-framework same asMicrosoft.NET.TestFramework.csprojto simplifyCreateTempSubdirectoryand deleting unused methods#45631