Simplify SB bootstrap package logic #46575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
This was referenced Feb 6, 2025
Open
mthalman
reviewed
Feb 6, 2025
src/SourceBuild/content/eng/bootstrap/buildBootstrapPreviouslySB.csproj
Outdated
Show resolved
Hide resolved
MichaelSimons
force-pushed
the
sb-bootstrap-packages
branch
from
b4585ba to
2aaf38d
Compare
|
@mthalman - I refactored a fair amount vs the initial draft. I think utilizing the PortableRid property with the existing pattern is best to ensure correctness as packages are added/removed. |
mthalman
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#3631
With the UB work, I propose refactoring the buildBootstrapPreviouslySB.csproj to make use of the PortableRid property to: