sln-add: Get project DefaultProjectTypeGuid #47661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-CLI
untriaged
There was a problem hiding this comment.
Pull Request Overview
This PR updates the handling of retrieving the project type GUID when adding a project to a solution by using the default project type GUID if the primary method returns null.
- Moved the instantiation of ProjectInstance before the try-catch block.
- Updated GUID retrieval to fallback to the default project type GUID.
- Removed duplicate instantiation of ProjectInstance.
|
Further update: One of these is skipped, while the other one must only matter when it can't find either the project type guid or the default project type guid |
Forgind
approved these changes
Mar 17, 2025
|
Also addresses #522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47638
Description and impact
When adding a new project that is not known for the SDK or MSBuild, it should read the
DefaultProjectTypeGuidproperty from the project file.Regression
Yes - this worked before 9.0.2xx
Risk
Low – Currently it errors when adding unknown project types, unless the
ProjectTypeGuidis specified on the project itself, or on the solution file.Testing
Unit tests on this were ambiguous, so they were renamed to better match their cases.
I was also able to reproduce the bug...
Existing behavior
Expected behavior
