Remove comment from Console template #49117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting this up for discussion given it's been multiple major releases since we introduced top-level statements as the default I think it's worth considering removing this comment from the console template to make the C# file cleaner. @baronfel @claudiaregio @stephentoub @timheuer
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy conditional compilation block and informational comment for the top-level program from the C# console template.
- Deletes the
#if (csharpFeature_TopLevelProgram)wrapper and its associated console-template link comment.
Member
|
Yes please! |
Member
Member
Author
|
Closing this in favor of #42497 which I didn't see before opening this one 😄 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up for discussion given it's been multiple major releases since we introduced top-level statements as the default I think it's worth considering removing this comment from the console template to make the C# file cleaner.
@baronfel @claudiaregio @stephentoub @timheuer