Remove longstanding comment from C# console template #42497
Conversation
ghost
added
|
Might need to touch a few more files? |
|
Yep - I authored this quickly from the web so was using CI as a gate to see what else needed doing while I worked on other things today. The approval tests will certainly need updating, but the static testassets can stay, as those are point-in-time resources used for other scenario-based tests. |
| }, | ||
| "ContainerBaseImage": { | ||
| "type": "string", | ||
| "defaultValue": "mcr.microsoft.com/dotnet/runtime:8.0", |
There was a problem hiding this comment.
8.0 intentional since this is main?
There was a problem hiding this comment.
Oh that file shouldn't even be checked in, it's not relevant to this template change at all. Let me revert it.
|
@baronfel is this for 9 or 10? |
|
It was gonna be for 9 but I am not at all sure I'll be able to get to it in time. |
|
lgtm, let's merge this ASAP? @baronfel |
baronfel
force-pushed
the
remove-comment-from-console-template
branch
from
a711f17 to
8416ec0
Compare
baronfel
force-pushed
the
remove-comment-from-console-template
branch
from
8416ec0 to
b32a52a
Compare
|
Replaced by #51527 |
Fix #36293 by removing this old comment.