-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup source build teams #4645
Labels
area-infra
Source-build infrastructure and reporting
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
1 similar comment
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
MichaelSimons
added a commit
to dotnet/sdk
that referenced
this issue
Oct 3, 2024
Related to dotnet/source-build#4645
github-actions bot
pushed a commit
to dotnet/sdk
that referenced
this issue
Oct 4, 2024
Related to dotnet/source-build#4645
This was referenced Oct 10, 2024
MichaelSimons
added
area-infra
Source-build infrastructure and reporting
and removed
untriaged
labels
Oct 10, 2024
This was referenced Oct 11, 2024
This was referenced Oct 11, 2024
mmitche
pushed a commit
to dotnet/diagnostics
that referenced
this issue
Oct 16, 2024
The @dotnet/source-build-internal team is being deprecated. All references to it were updated. Included the renaming of SourceBuild.props to the new naming convention, DotNetBuild.props. Related to dotnet/source-build#4645 Repo admins, please grant write access to @dotnet/product-construction and @dotnet/source-build. This is needed for the CODEOWNERS changes. Write access can be removed for @dotnet/source-build-internal. --------- Co-authored-by: Matt Thalman <mthalman@microsoft.com>
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem: The source-build-internal team is poorly named. It is comprised of the MSFT SB team members. We use it as "the" way to ping the SB team to get help or review SB related topics.
Misconception: The "internal" part is confusing. I field questions along the lines of "what team should we use?" they even often state that they have seen our documentation that says use source-build-internal but didn't think it was right. Folks are using source-build-contrib because it "feels" more appropriate. All 4 active mentions of source-build-contrib should have used source-build-internal
Recommendation: "Rename" the team to source-build. Update all documentation and references to the new team. Post announcements (internally and externally) to notify of the name change. The source-build-contrib team should be deleted.
Implementation:
When a GitHub team is renamed, all existing references must be updated manually. Because of this, a new source-build team should be created, update all documentation and CODEOWNER references to the new team, then delete the source-build-internal team.
The text was updated successfully, but these errors were encountered: