Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DotNetBuild.props header to correct reviewer #12300

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented Oct 10, 2024

Related to dotnet/source-build#4645

This file started off as being source-build specific but with the Unified Build project it has become more general therefore the header needed updating.

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46549%. Comparing base (c974051) to head (fb9c773).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12300         +/-   ##
===================================================
+ Coverage   75.46422%   75.46549%   +0.00127%     
===================================================
  Files           3106        3106                 
  Lines         634445      634445                 
  Branches       46887       46887                 
===================================================
+ Hits          478779      478787          +8     
+ Misses        152236      152228          -8     
  Partials        3430        3430                 
Flag Coverage Δ
Debug 75.46549% <ø> (+0.00127%) ⬆️
integration 17.98486% <ø> (-0.00035%) ⬇️
production 48.87715% <ø> (+0.00175%) ⬆️
test 97.02609% <ø> (+0.00086%) ⬆️
unit 45.91057% <ø> (+0.00211%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra merged commit b3e4f26 into dotnet:main Oct 10, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Oct 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants