Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop harvesting packages in runtime: remove prebuilts #1850

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

dagood
Copy link
Member

@dagood dagood commented Nov 2, 2020

Conditionally remove the import of restore\harvestPackages.targets to remove some PackageDownload elements bringing in prebuilts.

For #1844.

@dagood dagood self-assigned this Nov 2, 2020
@dagood dagood requested review from dseefeld and crummel November 2, 2020 22:43
@runfoapp runfoapp bot mentioned this pull request Nov 2, 2020
dseefeld added a commit to dseefeld/source-build that referenced this pull request Nov 3, 2020
Include patch to remove import of restore/harvestPackages.targets
in runtime libraries build to fix issue with portable build
@dagood
Copy link
Member Author

dagood commented Nov 3, 2020

The last leg succeeded but timed out during publish/cleanup. Now it's not able to get build agents for a retry due to https://github.com/dotnet/core-eng/issues/11320. Going ahead with merge since it was effectively green.

@dagood dagood merged commit 92d2aef into dotnet:master Nov 3, 2020
@dagood dagood deleted the libraries-packages-prebuilts branch November 3, 2020 03:23
dseefeld added a commit that referenced this pull request Nov 3, 2020
* Update to 5.0.100-rtm.20521.5, BAR Build ID 68494

* Update previously source-built to N-1

* Reconcile patches

Note: Removed aspnetcore version number patch because it is set to
a stable 5.0 version.
Note: Removed roslyn Humanizer removal patch because there is now
more usage of Humanizer in the code base.  May need to redo this
patch or add Humanizer.  (See #1767)

* Update to 5.0.100-rtm.20522.4, BAR Build ID 68583

* Update commits in Version.Details.xml and reconcile patches

* Remove temporary RC1 fix in aspnetcore

* Install built runtime for usage by aspnetcore

* Update roslyn to build CodeStyle packages

* Update / add installer patches

* Fix broken patch

* Update prevSourceBuilt to GA version

* Pin System.Security.Cryptography.Cng version in runtime build

* Update path to sdk installation

* Update smoke test nuget.config entries

* Update online prebuilt baseline

* Update package name for aspnetcore reference

* Add runtime feed to smoke-testNuGet.Config

* Update runtime config entry

* Update to 20201026.5, BAR Build ID 68880

* Set UseStableVersions flag

* Update online baseline

* Update offline prebuilt baseline

* Include patch from #1850

Include patch to remove import of restore/harvestPackages.targets
in runtime libraries build to fix issue with portable build

* Re-add portable build only prebuilts
MichaelSimons pushed a commit to dotnet/source-build-externals that referenced this pull request Feb 8, 2022
* Update to 5.0.100-rtm.20521.5, BAR Build ID 68494

* Update previously source-built to N-1

* Reconcile patches

Note: Removed aspnetcore version number patch because it is set to
a stable 5.0 version.
Note: Removed roslyn Humanizer removal patch because there is now
more usage of Humanizer in the code base.  May need to redo this
patch or add Humanizer.  (See dotnet/source-build#1767)

* Update to 5.0.100-rtm.20522.4, BAR Build ID 68583

* Update commits in Version.Details.xml and reconcile patches

* Remove temporary RC1 fix in aspnetcore

* Install built runtime for usage by aspnetcore

* Update roslyn to build CodeStyle packages

* Update / add installer patches

* Fix broken patch

* Update prevSourceBuilt to GA version

* Pin System.Security.Cryptography.Cng version in runtime build

* Update path to sdk installation

* Update smoke test nuget.config entries

* Update online prebuilt baseline

* Update package name for aspnetcore reference

* Add runtime feed to smoke-testNuGet.Config

* Update runtime config entry

* Update to 20201026.5, BAR Build ID 68880

* Set UseStableVersions flag

* Update online baseline

* Update offline prebuilt baseline

* Include patch from dotnet/source-build#1850

Include patch to remove import of restore/harvestPackages.targets
in runtime libraries build to fix issue with portable build

* Re-add portable build only prebuilts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants