Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop harvesting packages in runtime: remove prebuilts #1850

Merged
merged 1 commit into from
Nov 3, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
From e45904a0ce2e16d1fe49341af1dd4ab84ce729f5 Mon Sep 17 00:00:00 2001
From: Davis Goodin <dagood@microsoft.com>
Date: Mon, 2 Nov 2020 11:54:57 -0600
Subject: [PATCH] Remove libraries-packages.proj harvesting

Remove some prebuilts by removing package harvesting. Package harvesting
is not compatible with the concept of a prebuiltless source-build.
---
src/libraries/libraries-packages.proj | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libraries/libraries-packages.proj b/src/libraries/libraries-packages.proj
index f2eef864898..5e156775bcc 100644
--- a/src/libraries/libraries-packages.proj
+++ b/src/libraries/libraries-packages.proj
@@ -24,7 +24,7 @@
<Import Project="$(PkgDir)baseline\baseline.props" />

<!-- Calculate PackageDownload items for restore. -->
- <Import Project="$(RepositoryEngineeringDir)restore\harvestPackages.targets" Condition="'$(MSBuildRestoreSessionId)' != ''" />
+ <Import Project="$(RepositoryEngineeringDir)restore\harvestPackages.targets" Condition="'$(MSBuildRestoreSessionId)' != '' and '$(DotNetBuildFromSource)' != 'true'" />

<!--
Updates the package index to mark all packages we are building that can go stable as stable.
--
2.25.2