Initial implementation of direct git repo data reading #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2019
Closed
tmat
added a commit
that referenced
this pull request
Jun 22, 2019
Since #288 directories `.git/refs`, `.git/objects` are no longer required to be present
This was referenced Jun 22, 2019
Closed
|
Is there a published nuget version that has these fixes in it? |
|
Not yet. Still testing the package. |
omajid
added a commit
to omajid/dotnet-core-setup
that referenced
this pull request
Aug 13, 2019
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide whether to default to
x64 or to switch to arm64 when TargetArchitecture is not specified
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to filter the list of
found libclrjit.so files to pick the normal-RID (eg, linux-arm64)
libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes #7653
omajid
added a commit
to omajid/dotnet-core-setup
that referenced
this pull request
Aug 13, 2019
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide whether to default to
x64 or to switch to arm64 when TargetArchitecture is not specified
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to filter the list of
found libclrjit.so files to pick the normal-RID (eg, linux-arm64)
libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes #7653
omajid
added a commit
to omajid/dotnet-core-setup
that referenced
this pull request
Aug 13, 2019
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide whether to default to
x64 or to switch to arm64 when TargetArchitecture is not specified
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to filter the list of
found libclrjit.so files to pick the normal-RID (eg, linux-arm64)
libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes #7653
omajid
added a commit
to omajid/dotnet-core-setup
that referenced
this pull request
Aug 13, 2019
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide whether to default to
x64 or to switch to arm64 when TargetArchitecture is not specified
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to filter the list of
found libclrjit.so files to pick the normal-RID (eg, linux-arm64)
libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes #7653
omajid
added a commit
to omajid/dotnet-core-setup
that referenced
this pull request
Aug 14, 2019
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide the HostArch. Use that
as the default value of TargetArchitecture, unless another value was
provided by the build configuration.
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to pick the normal-RID
(eg, linux-arm64) libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes #7653
dagood
pushed a commit
to dotnet/core-setup
that referenced
this pull request
Aug 15, 2019
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide the HostArch. Use that
as the default value of TargetArchitecture, unless another value was
provided by the build configuration.
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to pick the normal-RID
(eg, linux-arm64) libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes #7653
This was referenced Aug 20, 2019
Ivanidzo4ka
pushed a commit
to microsoft/fhir-server
that referenced
this pull request
Feb 18, 2021
It was disabled in #262, but instead of been disabled only for OSx it was never set to be true at first place, so it was off for all platforms. Regarding OSx it looks like bug was fixed somewhere around 2019 (dotnet/sourcelink#288)
4 tasks
Ivanidzo4ka
pushed a commit
to microsoft/fhir-server
that referenced
this pull request
Feb 19, 2021
It was disabled in #262, but instead of been disabled only for OSx it was never set to be true at first place, so it was off for all platforms. Regarding OSx it looks like bug was fixed somewhere around 2019 (dotnet/sourcelink#288)
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
To enable building core-setup on arm64 (hosted, not cross compiled), we
need to do a few things:
- Set the right TargetArchitecture
Use the currently running architecture to decide the HostArch. Use that
as the default value of TargetArchitecture, unless another value was
provided by the build configuration.
- Use the right coreclr JIT
If we are cross-compiling, we need to use the x86_arm64 libclrjit.so.
But if we are building on an arm64 host, we need to pick the normal-RID
(eg, linux-arm64) libclrjit.so from the two:
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/linux-arm64/native/libclrjit.so
./.packages/transport.runtime.linux-arm64.microsoft.netcore.jit/###/runtimes/x64_arm64/native/libclrjit.so
- Use a version of SourceLink that supports arm64
We need to upgrade SourceLink to a version that contains
dotnet/sourcelink#288. This commit just
updates it to the latest version.
Fixes dotnet/core-setup#7653
Commit migrated from dotnet/core-setup@4b82b1e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace usage of libgit2 APIs with fully managed implementation. This will make SourceLink available on all platforms that the Core CLR supports as well as in source build scenarios.
Fixes #256
Fixes #155
Fixes #231
Fixes #236