Update Microsoft.Dotnet.Arcade.Wpf.Sdk to accommodate changes to Microsoft.Build.Tasks.Git tasks #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild.Tasks.Git tasks
…atest") to get the new Arcade SDK
ghost
requested review from
ghost
added
the
ryalanms
changed the title
|
Hello @vatsan-madhavan! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Builds have succeeded - merging (Helix seems to be stuck). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Microsoft.Dotnet.Arcade.Wpf.Sdk to accommodate changes to Microsoft.Build.Tasks.Git tasks
dotnet/sourcelink#288
WPF internal builds are failing with parameter not supported error:
##[error].packages\microsoft.dotnet.arcade.wpf.sdk\4.8.0-preview7.19324.12\tools\Packaging.targets(375,49): error MSB4064: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Directory" parameter is not supported by the "Microsoft.Build.Tasks.Git.LocateRepository" task. Verify the parameter exists on the task, and it is a settable public instance property.
##[error].packages\microsoft.dotnet.arcade.wpf.sdk\4.8.0-preview7.19324.12\tools\Packaging.targets(375,5): error MSB4063: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.Build.Tasks.Git.LocateRepository" task could not be initialized with its input parameters.
Fix
GenerateVersionFileWithRepositoryCommittarget and update .NET tools to include new Arcade SDK.