Implement validation of Template Choice Parameter values #4650
Assignees
Labels
area: authoring
Enhancements to the process of authoring, maintaining, and testing templates
triaged
The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone
Comments
baronfel
added
the
area: authoring
vlada-shubina
added
the
triaged
Closed
3 tasks
|
The error/warning should be shown if such template is attempted to be installed/instantiated, until we have MSBuild task for that. |
JanKrivanek
added a commit
to JanKrivanek/templating
that referenced
this issue
May 9, 2022
This was referenced May 9, 2022
JanKrivanek
added a commit
that referenced
this issue
May 10, 2022
|
This is now part of the template validation checks - those happen before template installation and instantiation. |
JanKrivanek
added a commit
that referenced
this issue
May 13, 2022
* #4490 implementing support for quote-less choice literals (#4574) * #4490 implementing support for quote-less choice literals * Testfix * Make the unquoted literals feature opt-in via EnableQuotelessLiterals property * Localize error message * Fix code and tests after merge * Multichoice implementation contd (#4666) * #4490 implementing support for quote-less choice literals * #4490 multichoice parameters implementation * Add Tab completion test cases * Fix code + tests after merge * Fix code and unit tests after merging * Add support for multichoice parameters in join macro * Improve based on review comments * fix #4650 - adding validation for multichoice symbols (#4698) * fix #4650 - adding validation for multichoice symbols * Adjust error message * Multichoice refactor quoteless (#4708) * #4665 Refactoring part 1: Make EnableQuotelessLiterals exposed only to Orchestrator * Fix parameters localization * Fix after merge
JanKrivanek
added a commit
that referenced
this issue
May 26, 2022
…ft.TemplateEngine.Abstractions (#4717) * #4490 implementing support for quote-less choice literals (#4574) * #4490 implementing support for quote-less choice literals * Testfix * Make the unquoted literals feature opt-in via EnableQuotelessLiterals property * Localize error message * Fix code and tests after merge * Multichoice implementation contd (#4666) * #4490 implementing support for quote-less choice literals * #4490 multichoice parameters implementation * Add Tab completion test cases * Fix code + tests after merge * Fix code and unit tests after merging * Add support for multichoice parameters in join macro * Improve based on review comments * fix #4650 - adding validation for multichoice symbols (#4698) * fix #4650 - adding validation for multichoice symbols * Adjust error message * #4665 Refactoring part 1: Make EnableQuotelessLiterals exposed only to Orchestrator * Fix parameters localization * #4665: Refactor step 2 - lower the Core dependency on Abstractions * Fix tests - proper fixtures typing * Fix tests after refactorings - mainly issues with PhysicalFileSystem * Fix tests * Revert back to mounted file system in orchestrator for source files * fix api * Improve - further removal of IEnvironemnt, test logger improvement, nullability to api, other * Fix test bug - add log providers to test log factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be nice to expand our template validation MSBuild Tasks to validate that the values of Choice parameters are valid - meaning that they do not contain
|or,characters so that they are valid for multi-selects (which use these characters as the delimiters).This came out of discussions over #4490.
The text was updated successfully, but these errors were encountered: