Multichoice implementation contd #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/JanKrivanek/templating into multichoice-implementation-contd
JanKrivanek
commented
May 3, 2022
vlada-shubina
approved these changes
May 4, 2022
...Microsoft.TemplateEngine.Orchestrator.RunnableProjects.UnitTests/MacroTests/JoinMacroTest.cs
Outdated
Show resolved
Hide resolved
| // Template content preparation | ||
| // | ||
|
|
||
| string templateConfig = @" |
There was a problem hiding this comment.
(not actionable):
couple of ideas how to avoid strings (they a hard to manage)
- use anonymous classes where members match properties
- after recent refactoring you can create
SimpleConfigModeland init its fields
There was a problem hiding this comment.
I actually considered those test to be a typo of e2e test that can be a bit more performant - so I prefered the input to be as unprocessed as possible
| { | ||
| return match; | ||
| } | ||
| List<string?> val = literal.Tokenize().Select(t => ResolveChoice(environmentSettings, t, param)).Where(r => !string.IsNullOrEmpty(r)).ToList(); |
There was a problem hiding this comment.
(not actionable)
it would be great to move from string, string relation to string, object or string, IParameterValue relation for template parameters as part of the further refactoring
There was a problem hiding this comment.
Yeah - that would be much better. However we still likely would need to keep it in edge contracts
vlada-shubina
approved these changes
May 9, 2022
Merged
JanKrivanek
added a commit
that referenced
this pull request
May 13, 2022
* #4490 implementing support for quote-less choice literals (#4574) * #4490 implementing support for quote-less choice literals * Testfix * Make the unquoted literals feature opt-in via EnableQuotelessLiterals property * Localize error message * Fix code and tests after merge * Multichoice implementation contd (#4666) * #4490 implementing support for quote-less choice literals * #4490 multichoice parameters implementation * Add Tab completion test cases * Fix code + tests after merge * Fix code and unit tests after merging * Add support for multichoice parameters in join macro * Improve based on review comments * fix #4650 - adding validation for multichoice symbols (#4698) * fix #4650 - adding validation for multichoice symbols * Adjust error message * Multichoice refactor quoteless (#4708) * #4665 Refactoring part 1: Make EnableQuotelessLiterals exposed only to Orchestrator * Fix parameters localization * Fix after merge
JanKrivanek
added a commit
that referenced
this pull request
May 26, 2022
…ft.TemplateEngine.Abstractions (#4717) * #4490 implementing support for quote-less choice literals (#4574) * #4490 implementing support for quote-less choice literals * Testfix * Make the unquoted literals feature opt-in via EnableQuotelessLiterals property * Localize error message * Fix code and tests after merge * Multichoice implementation contd (#4666) * #4490 implementing support for quote-less choice literals * #4490 multichoice parameters implementation * Add Tab completion test cases * Fix code + tests after merge * Fix code and unit tests after merging * Add support for multichoice parameters in join macro * Improve based on review comments * fix #4650 - adding validation for multichoice symbols (#4698) * fix #4650 - adding validation for multichoice symbols * Adjust error message * #4665 Refactoring part 1: Make EnableQuotelessLiterals exposed only to Orchestrator * Fix parameters localization * #4665: Refactor step 2 - lower the Core dependency on Abstractions * Fix tests - proper fixtures typing * Fix tests after refactorings - mainly issues with PhysicalFileSystem * Fix tests * Revert back to mounted file system in orchestrator for source files * fix api * Improve - further removal of IEnvironemnt, test logger improvement, nullability to api, other * Fix test bug - add log providers to test log factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#4490
Solution
Checks:
#nullable enableto all the modified files ?