Allow uninstallation of global .NET Installations #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now what is hitting the EPERM and ENOENT errors. We need to skip the check and see what happens from here, such as allowing to elevate via windows. This also adds specific handlers for when we fail to download the SDK.
Need to double check that cancelling is handled properly now that its a promise reject
we need to fix the uninstallglobal functoin logic to print out and such still then test it
… open stdin on uninstall
…due to this at the end
smitpatel
reviewed
Aug 13, 2024
smitpatel
reviewed
Aug 13, 2024
smitpatel
reviewed
Aug 13, 2024
smitpatel
reviewed
Aug 13, 2024
smitpatel
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global Uninstall
Allows uninstall of global .NET SDKs.
For windows, use /uninstall flag on the installer.
For mac, use sudo rm rf as /uninstall flag DNE on mac
For linux, use apt-get remove. (pre-existing code with pre-existing tests)
Other Code Changes
Sets a
DEBIANT_FRONTENDenvironment variable temporarily in the shell script process to prevent apt-get remove from trying to grab stdin which may be busy.Adds an
exit.txtvariable to tell themaster sudoprocess to die. Sometimes this process will hold onto the lock after install/uninstall and then this causes problems. Resolves #1904Adds
-rfto the final process trap exit to prevent failure due to file DNE if it's already been cleaned up before the process dies.Adds pre-existing images which used to be ignored for some reason.
Uses VS Code Icon Pack to be compliant with iconography restrictions and also keep icons updated per API instead of trying to invoke win-32 API to get the UAC icon.
Increase DPKG lock timeout to 180 seconds as it can sometimes take longer.
Adds -y to some commands which may be necessary with DEBIAN_FRONTEND.
UI
Adds a UI to uninstall a local or global .NET installation from the user.
Base command:
Picking an installation:
Has warning menu if you try to uninstall a .NET version which will break an extension which relies on that installation.
Uninstall Experience
Windows, non-elevated:
This output window appears. If not-elevated, UAC prompt will appear, no further intervention is required.
(this text is old, it now just says uninstalled)
Mac:
Password prompt will appear to elevate to uninstall.
Linux:
If no installs exist:
Context menu will show no installs.