Allow uninstallation of global .NET Installations

.gitignore

@@ -45,7 +45,6 @@ install.*
 .vscode-test/
 *.vsix
 vscode-dotnet-runtime-library/install scripts/dotnet-install.*
-*/images/*
 vscode-dotnet-runtime-extension/LICENSE.txt
 vscode-dotnet-sdk-extension/LICENSE.txt
 .vscode/launch.json

vscode-dotnet-runtime-extension/CHANGELOG.md

@@ -9,10 +9,34 @@ and this project adheres to [Semantic Versioning].
 
 ## [2.1.2] - 2024-08-01
 
-Adds the ability to uninstall a particular runtime.
+Adds the ability for users to uninstall things themselves.
+
+Adds the ability to uninstall a global installation that is already managed by the extension.
+
+Adds API for extensions to uninstall a singular runtime rather than all runtimes.
+
+Adds offline support so existing installations can be found when offline.
 
 Adds additional signatures to the release.
 
+Fixes 'Lock' acquisition issues.
+
+Fixes a bug with DEBIAN_FRONTEND when installing an SDK on Ubuntu.
+
+Fixes a bug with offline detection.
+
+Fixed a bug with arm64 windows installation detection logic.
+
+Fixed a bug when preview versions are installed by Visual Studio.
+
+Fixes a bug where apt-get lock can be busy. Fixes a bug where stdin can be busy.
+
+Fixes a bug with installation detection of SDKS.
+
+Updates Axios per CVE release.
+
+Migrates to a newer version of typescript and node under the hood. Requires a newer version of VS Code.
+
 Fixes other minor bugs.
 
 ## [2.1.1] - 2024-07-18

vscode-dotnet-runtime-extension/package.json

@@ -16,7 +16,7 @@
 	"version": "2.1.2",
 	"publisher": "ms-dotnettools",
 	"engines": {
-		"vscode": "^1.74.0"
+		"vscode": "^1.81.1"
 	},
 	"categories": [
 		"Other"
@@ -51,6 +51,11 @@
 				"title": "Install the .NET SDK System-Wide.",
 				"category": ".NET Install Tool",
 				"enablement": "!dotnetAcquisitionExtension.isGlobalSDKUnsupported"
+			},
+            {
+				"command": "dotnet.uninstallPublic",
+				"title": "Uninstall .NET.",
+				"category": ".NET Install Tool"
 			}
 		],
 		"configuration": {

vscode-dotnet-runtime-extension/src/extension.ts

@@ -61,14 +61,17 @@ import {
     DotnetInstallType,
     DotnetAcquisitionTotalSuccessEvent,
     isRunningUnderWSL,
+    InstallRecord,
     getMajor,
     getMajorMinor,
-    DotnetOfflineWarning
+    DotnetOfflineWarning,
 } from 'vscode-dotnet-runtime-library';
 import { dotnetCoreAcquisitionExtensionId } from './DotnetCoreAcquisitionId';
-import { IDotnetCoreAcquisitionWorker } from 'vscode-dotnet-runtime-library/dist/Acquisition/IDotnetCoreAcquisitionWorker';
+import { InstallTrackerSingleton } from 'vscode-dotnet-runtime-library/dist/Acquisition/InstallTrackerSingleton';
 
 // tslint:disable no-var-requires
+/* tslint:disable:only-arrow-functions */
+
 const packageJson = require('../package.json');
 
 // Extension constants
@@ -79,11 +82,13 @@ namespace configKeys {
     export const existingSharedPath = 'sharedExistingDotnetPath'
     export const proxyUrl = 'proxyUrl';
 }
+
 namespace commandKeys {
     export const acquire = 'acquire';
     export const acquireGlobalSDK = 'acquireGlobalSDK';
     export const acquireStatus = 'acquireStatus';
     export const uninstall = 'uninstall';
+    export const uninstallPublic = 'uninstallPublic'
     export const uninstallAll = 'uninstallAll';
     export const listVersions = 'listVersions';
     export const recommendedVersion = 'recommendedVersion'
@@ -307,7 +312,7 @@ export function activate(vsCodeContext: vscode.ExtensionContext, extensionContex
         globalEventStream.post(new GlobalAcquisitionContextMenuOpened(`The user has opened the global SDK acquisition context menu.`));
 
         const recommendedVersionResult : IDotnetListVersionsResult = await vscode.commands.executeCommand('dotnet.recommendedVersion');
-        const recommendedVersion : string = recommendedVersionResult ? recommendedVersionResult[0].version : '';
+        const recommendedVersion : string = recommendedVersionResult ? recommendedVersionResult[0]?.version : '';
 
         const chosenVersion = await vscode.window.showInputBox(
         {
@@ -354,6 +359,77 @@ export function activate(vsCodeContext: vscode.ExtensionContext, extensionContex
         return pathResult;
     });
 
+    const dotnetUninstallPublicRegistration = vscode.commands.registerCommand(`${commandPrefix}.${commandKeys.uninstallPublic}`, async () =>
+    {
+        const existingInstalls = await InstallTrackerSingleton.getInstance(globalEventStream, vsCodeContext.globalState).getExistingInstalls(true);
+
+        const menuItems = existingInstalls?.sort(
+        function(x : InstallRecord, y : InstallRecord) : number
+        {
+            if(x.dotnetInstall.installMode === y.dotnetInstall.installMode)
+            {
+                return x.dotnetInstall.version.localeCompare(y.dotnetInstall.version);
+            }
+            return x.dotnetInstall.installMode.localeCompare(y.dotnetInstall.installMode);
+        })?.map(install =>
+        {
+            return {
+                label : `.NET ${(install.dotnetInstall.installMode === 'sdk' ? 'SDK' : install.dotnetInstall.installMode === 'runtime' ? 'Runtime' : 'ASP.NET Core Runtime')} ${install.dotnetInstall.version}`,
+                description : `${install.dotnetInstall.architecture ?? ''} | ${install.dotnetInstall.isGlobal ? 'machine-wide' : 'vscode-local' }`,
+                detail : install.installingExtensions.some(x => x !== null) ? `Used by ${install.installingExtensions.join(', ')}` : ``,
+                iconPath : install.dotnetInstall.isGlobal ? new vscode.ThemeIcon('shield') : new vscode.ThemeIcon('trash'),
+                internalId : install.dotnetInstall.installId
+            }
+        });
+
+        if(menuItems.length < 1)
+        {
+            vscode.window.showInformationMessage('No .NET installations were found to uninstall.');
+            return;
+        }
+
+        const chosenVersion = await vscode.window.showQuickPick(menuItems, { placeHolder: 'Select a version to uninstall.' });
+
+        if(chosenVersion)
+        {
+            const installRecord : InstallRecord = existingInstalls.find(install => install.dotnetInstall.installId === chosenVersion.internalId)!;
+
+            if(!installRecord || !installRecord?.dotnetInstall?.version || !installRecord?.dotnetInstall?.installMode)
+            {
+                return;
+            }
+
+            const selectedInstall : DotnetInstall = installRecord.dotnetInstall;
+            let canContinue = true;
+            const uninstallWillBreakSomething = !(await InstallTrackerSingleton.getInstance(globalEventStream, vsCodeContext.globalState).canUninstall(true, selectedInstall, true));
+
+            const yes = `Continue`;
+            if(uninstallWillBreakSomething)
+            {
+                const pick = await vscode.window.showWarningMessage(
+`Uninstalling .NET ${selectedInstall.version} will likely cause ${installRecord.installingExtensions.some(x => x !== null) ? installRecord.installingExtensions.join(', ') : 'extensions such as C# or C# DevKit'} to stop functioning properly. Do you still wish to continue?`, { modal: true }, yes);
+                canContinue = pick === yes;
+            }
+
+            if(!canContinue)
+            {
+                return;
+            }
+
+            const commandContext : IDotnetAcquireContext =
+            {
+                version: selectedInstall.version,
+                mode: selectedInstall.installMode,
+                installType: selectedInstall.isGlobal ? 'global' : 'local',
+                architecture: selectedInstall.architecture,
+                requestingExtensionId : 'user'
+            }
+
+            outputChannel.show(true);
+            return uninstall(commandContext, true);
+        }
+    });
+
     /**
      * @returns 0 on success. Error string if not.
      */
@@ -362,7 +438,7 @@ export function activate(vsCodeContext: vscode.ExtensionContext, extensionContex
         return uninstall(commandContext);
     });
 
-    async function uninstall(commandContext: IDotnetAcquireContext | undefined) : Promise<string>
+    async function uninstall(commandContext: IDotnetAcquireContext | undefined, force = false) : Promise<string>
     {
         let result = '1';
         await callWithErrorHandling(async () =>
@@ -378,21 +454,26 @@ export function activate(vsCodeContext: vscode.ExtensionContext, extensionContex
                 {
                     const worker = getAcquisitionWorker();
                     const workerContext = getAcquisitionWorkerContext(commandContext.mode, commandContext);
-                    const versionResolver = new VersionResolver(workerContext);
-                    const resolvedVersion = await versionResolver.getFullVersion(commandContext.version, commandContext.mode);
-                    commandContext.version = resolvedVersion;
+
+                    if(commandContext.installType === 'local' && !force) // if using force mode, we are also using the UI, which passes the fully specified version to uninstall only
+                    {
+                        const versionResolver = new VersionResolver(workerContext);
+                        const resolvedVersion = await versionResolver.getFullVersion(commandContext.version, commandContext.mode);
+                        commandContext.version = resolvedVersion;
+                    }
 
                     const installationId = getInstallIdCustomArchitecture(commandContext.version, commandContext.architecture, commandContext.mode, commandContext.installType);
                     const install = {installId : installationId, version : commandContext.version, installMode: commandContext.mode, isGlobal: commandContext.installType === 'global',
                         architecture: commandContext.architecture ?? DotnetCoreAcquisitionWorker.defaultArchitecture()} as DotnetInstall;
 
                     if(commandContext.installType === 'local')
                     {
-                        result = await worker.uninstallLocalRuntimeOrSDK(workerContext, install);
+                        result = await worker.uninstallLocal(workerContext, install, force);
                     }
                     else
                     {
-                        result = await worker.uninstallGlobal(workerContext, install);
+                        const globalInstallerResolver = new GlobalInstallerResolver(workerContext, commandContext.version);
+                        result = await worker.uninstallGlobal(workerContext, install, globalInstallerResolver, force);
                     }
                 }
         }, getIssueContext(existingPathConfigWorker)(commandContext?.errorConfiguration, 'uninstall'));
@@ -591,6 +672,7 @@ We will try to install .NET, but are unlikely to be able to connect to the serve
         dotnetListVersionsRegistration,
         dotnetRecommendedVersionRegistration,
         dotnetUninstallRegistration,
+        dotnetUninstallPublicRegistration,
         dotnetUninstallAllRegistration,
         showOutputChannelRegistration,
         ensureDependenciesRegistration,

vscode-dotnet-runtime-library/distro-data/distro-support.json

@@ -7,7 +7,7 @@
                 "commandRoot": "apt-get",
                 "commandParts": [
                     "-o",
-                    "DPkg::Lock::Timeout=120",
+                    "DPkg::Lock::Timeout=180",
                     "update"
                 ]
             },
@@ -16,7 +16,7 @@
                 "commandRoot": "apt-get",
                 "commandParts": [
                     "-o",
-                    "DPkg::Lock::Timeout=120",
+                    "DPkg::Lock::Timeout=180",
                     "install",
                     "-y",
                     "{packageName}"
@@ -29,8 +29,9 @@
                 "commandRoot": "apt-get",
                 "commandParts": [
                     "-o",
-                    "DPkg::Lock::Timeout=120",
+                    "DPkg::Lock::Timeout=180",
                     "remove",
+                    "-y",
                     "{packageName}"
                 ]
             }
@@ -41,16 +42,17 @@
                 "commandRoot": "apt-get",
                 "commandParts": [
                     "-o",
-                    "DPkg::Lock::Timeout=120",
-                    "update"
+                    "DPkg::Lock::Timeout=180",
+                    "update",
+                    "-y"
                 ]
             },
             {
                 "runUnderSudo": true,
                 "commandRoot": "apt-get",
                 "commandParts": [
                     "-o",
-                    "DPkg::Lock::Timeout=120",
+                    "DPkg::Lock::Timeout=180",
                     "upgrade",
                     "-y",
                     "{packageName}"
@@ -63,7 +65,7 @@
                 "commandRoot": "apt-cache",
                 "commandParts": [
                     "-o",
-                    "DPkg::Lock::Timeout=120",
+                    "DPkg::Lock::Timeout=180",
                     "search",
                     "--names-only",
                     "^{packageName}$"
@@ -198,7 +200,7 @@
                         "commandRoot": "apt-get",
                         "commandParts": [
                             "-o",
-                            "DPkg::Lock::Timeout=120",
+                            "DPkg::Lock::Timeout=180",
                             "install",
                             "-y",
                             "wget"
@@ -226,7 +228,7 @@
                         "commandRoot": "apt-get",
                         "commandParts": [
                             "-o",
-                            "DPkg::Lock::Timeout=120",
+                            "DPkg::Lock::Timeout=180",
                             "update"
                         ]
                     }
@@ -240,7 +242,7 @@
                         "commandRoot": "apt-get",
                         "commandParts": [
                             "-o",
-                            "DPkg::Lock::Timeout=120",
+                            "DPkg::Lock::Timeout=180",
                             "update"
                         ]
                     },

vscode-dotnet-runtime-library/install scripts/interprocess-communicator.sh

@@ -3,15 +3,18 @@ EXECFOLDER=$1 # First argument is the working folder as this is launched with cw
 TIMEOUT_SEC=$2
 OKSIGNALFILE="$EXECFOLDER/ok.txt"
 COMMANDTORUNFILE="$EXECFOLDER/command.txt"
+EXITFILE="$EXECFOLDER/exit.txt"
 #OUTPUTFILE="/home/test_output_.txt"
 end=$((SECONDS+3600))
 
 function finish {
-  rm "$COMMANDTORUNFILE"
-  rm "$OKSIGNALFILE"
+  rm -f "$COMMANDTORUNFILE"
+  rm -f "$OKSIGNALFILE"
 }
 trap finish EXIT
 
+export DEBIAN_FRONTEND=noninteractive
+
 while true
 do
         stop=false
@@ -41,6 +44,10 @@ do
             if test -f "$OKSIGNALFILE"; then
                 rm "$OKSIGNALFILE"
             fi
+            if test -f "$EXITFILE"; then
+                rm "$EXITFILE"
+                exit 0
+            fi
             sleep 5
         done
 done