Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTM stable branding #4390

Merged
merged 12 commits into from
Oct 19, 2020
Merged

RTM stable branding #4390

merged 12 commits into from
Oct 19, 2020

Conversation

HongGit
Copy link
Contributor

@HongGit HongGit commented Oct 9, 2020

Please don't merge yet.

@HongGit HongGit requested a review from mmitche October 9, 2020 22:27
mconnew and others added 9 commits October 12, 2020 15:43
Co-authored-by: Matt Connew <matt.connew@microsoft.com>
[master] Update dependencies from dotnet/arcade
Co-authored-by: Matt Connew <matt.connew@microsoft.com>
Co-authored-by: Matt Connew <matt.connew@microsoft.com>
* Since all WCF assemblies share the same assembly version number no need to update more than one location.

Co-authored-by: Hong Li <hongli@microsoft.com>
…014.1 (#4399)

[master] Update dependencies from dotnet/arcade
* WSFederationHttpBinding.CreateMessgeSecurity uses Security.Message.EstablishSecurityContext to control SCT bootstrap
Remove Target and EstablishSecurityContest properties from WSTrustTokenParameters
Use DiagnosticUtility to trace exceptions
Remove M.IM.Logging direct dependency
Add comments to Federation classes
Format comments using InvariantCulture

* Fixed grammer and typos
Check for WSTrustParameters as IssuedSecurityTokenParameters in ctor of WSTrustChannelSecurityTokenProvider
Use DiagnosticUtility when throwing

* Add static helpers for WS and WS2007
Add test endpoints for WS and WS2007

Co-authored-by: brentschmaltz <brentschmaltz@hotmail.com>
Co-authored-by: Matt Connew <matt.connew@microsoft.com>
@HongGit
Copy link
Contributor Author

HongGit commented Oct 19, 2020

/azap

@mconnew
Copy link
Member

mconnew commented Oct 19, 2020

@HongGit, the mac failures are an infrastructure problem. It's having problems downloading the .NET Core runtime. This happened to me with another PR. Once all the other tests have completed you can go to devops and rerun just those failed steps and it should work.

@HongGit
Copy link
Contributor Author

HongGit commented Oct 19, 2020

thanks @mconnew !

@HongGit HongGit merged commit f0fc1ff into dotnet:master Oct 19, 2020
@HongGit HongGit deleted the hongli/gabranding branch October 20, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants