Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code. #4397

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Remove dead code. #4397

merged 1 commit into from
Oct 16, 2020

Conversation

imcarolwang
Copy link
Contributor

For issue #4377. Have run tests locally with the change applied, see no regression.

@HongGit , @mconnew .

@mconnew
Copy link
Member

mconnew commented Oct 16, 2020

Fixes #4377

@mconnew mconnew merged commit ee6ec8d into dotnet:master Oct 16, 2020
HongGit added a commit that referenced this pull request Oct 19, 2020
* RTM stable branding

* Add limited support for SpnEndpointIdentity with HTTP (#4385)

Co-authored-by: Matt Connew <matt.connew@microsoft.com>

* [master] Update dependencies from dotnet/arcade (#4388)

[master] Update dependencies from dotnet/arcade

* Enable ETW error logging for S.SM.Federation (#4391)

Co-authored-by: Matt Connew <matt.connew@microsoft.com>

* Fix OneWay only contracts with ReliableSessions (#4395)

Co-authored-by: Matt Connew <matt.connew@microsoft.com>

* Create central assembly version property for WCF assemblies. (#4221)

* Since all WCF assemblies share the same assembly version number no need to update more than one location.

Co-authored-by: Hong Li <hongli@microsoft.com>

* Remove dead code. (#4397)

* update product version for GA release (#4396)

* Update dependencies from https://github.com/dotnet/arcade build 20201014.1 (#4399)

[master] Update dependencies from dotnet/arcade

* WSFed static helpers and expanded tests (#4400)

* WSFederationHttpBinding.CreateMessgeSecurity uses Security.Message.EstablishSecurityContext to control SCT bootstrap
Remove Target and EstablishSecurityContest properties from WSTrustTokenParameters
Use DiagnosticUtility to trace exceptions
Remove M.IM.Logging direct dependency
Add comments to Federation classes
Format comments using InvariantCulture

* Fixed grammer and typos
Check for WSTrustParameters as IssuedSecurityTokenParameters in ctor of WSTrustChannelSecurityTokenProvider
Use DiagnosticUtility when throwing

* Add static helpers for WS and WS2007
Add test endpoints for WS and WS2007

Co-authored-by: brentschmaltz <brentschmaltz@hotmail.com>
Co-authored-by: Matt Connew <matt.connew@microsoft.com>

* RTM stable branding

Co-authored-by: Matt Connew <mconnew@microsoft.com>
Co-authored-by: Matt Connew <matt.connew@microsoft.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Stephen Bonikowsky <stebon@microsoft.com>
Co-authored-by: Carol Wang <v-carwan@microsoft.com>
Co-authored-by: brentschmaltz <brentschmaltz@hotmail.com>
@imcarolwang imcarolwang deleted the RemoveDeadCode branch July 8, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants