Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi target type reuse #5300

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

imcarolwang
Copy link
Contributor

@imcarolwang imcarolwang commented Sep 28, 2023

Allow muti-target framework project reuse referenced assembly types when adding wcf service reference, the fix use the best fit .NET target to load its referenced assemblies for type reuse.

Related issue from the community: https://developercommunity.visualstudio.com/t/Cannot-Reuse-types-in-referenced-assembl/10262818

@imcarolwang imcarolwang force-pushed the multiTargetTypeReuse branch 3 times, most recently from 9382ce6 to 853f999 Compare October 11, 2023 07:45
@imcarolwang imcarolwang requested a review from HongGit October 13, 2023 01:57
@imcarolwang imcarolwang force-pushed the multiTargetTypeReuse branch 3 times, most recently from 119ad59 to 6272864 Compare February 4, 2024 09:10
@imcarolwang imcarolwang force-pushed the multiTargetTypeReuse branch from 6272864 to 5c61c9f Compare March 21, 2024 09:43
@imcarolwang imcarolwang merged commit b9bff7d into dotnet:main Mar 27, 2024
8 checks passed
imcarolwang added a commit that referenced this pull request Apr 30, 2024
* Support referenced assembly type reuse for multi-target project

* Resolve reabse conflict.

* rebase and fix test issue.

* Apply workaround for reusing WindowsAppSDK pkg types in maui 7.0-xxx project

* Rebase and resolve conflicts.
imcarolwang added a commit that referenced this pull request Apr 30, 2024
imcarolwang added a commit to imcarolwang/wcf that referenced this pull request Apr 30, 2024
* Support referenced assembly type reuse for multi-target project

* Resolve reabse conflict.

* rebase and fix test issue.

* Apply workaround for reusing WindowsAppSDK pkg types in maui 7.0-xxx project

* Rebase and resolve conflicts.
organich pushed a commit to organich/wcf that referenced this pull request Aug 31, 2024
* Support referenced assembly type reuse for multi-target project

* Resolve reabse conflict.

* rebase and fix test issue.

* Apply workaround for reusing WindowsAppSDK pkg types in maui 7.0-xxx project

* Rebase and resolve conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants