Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when clicking on the value of PropertyGrid's property under JAWS tool #6704

Closed
Amy-Li03 opened this issue Feb 17, 2022 · 6 comments · Fixed by #6747
Closed

Exception when clicking on the value of PropertyGrid's property under JAWS tool #6704

Amy-Li03 opened this issue Feb 17, 2022 · 6 comments · Fixed by #6747
Assignees
@vladimir-krestov
Labels
Priority:1 Work that is critical for the release, but we could probably ship without tenet-accessibility MAS violation, UIA issue; problems with accessibility standards

Comments

@Amy-Li03
Copy link
Contributor

  • .NET Core Version:
    .NET SDK 7.0.100-preview.2.22103

  • Have you experienced this same bug with .NET Framework?:
    No

  • More info:

  1. This issue reproduces on .NET 5.0 & .NET 6.0 & .NET 7.0
  2. This issue doesn't repro on .NET Core 3.1
  3. VS with other tool(e.g. Narrator) doesn't repro this issue

Steps to reproduce:
TestApp.zip

  1. Create a .NET Core WinForms projects with any control added(E.g. Checkbox)
  2. Set the SelelctedObject property of propertyGrid to the checkBox control
  3. Run this project
  4. Launch the JAWS tool
  5. Clicking using mouse or press "Tab" keyboard on the value of propertyGrid's property
    Actual

Expected behavior:
No exception was throwing.

Actual behavior:
There is an exception was throwing
image

Call Stack:
System.ExecutionEngineException
HResult=0x80131506
Source= Cannot evaluate the exception source
StackTrace: Cannot evaluate the exception stack trace
@Olina-Zhang Olina-Zhang added the tenet-accessibility MAS violation, UIA issue; problems with accessibility standards label Feb 17, 2022
@Tanya-Solyanik Tanya-Solyanik changed the title There is an exception was throwing when clicking on the value of propertyGrid's property with JASW tool is launched Exception when clicking on the value of PropertyGrid's property under JAWS tool Feb 17, 2022
@Tanya-Solyanik Tanya-Solyanik added the Priority:1 Work that is critical for the release, but we could probably ship without label Feb 17, 2022
@RussKie RussKie added this to the 7.0 Preview3 milestone Feb 17, 2022
@MelonWang1 MelonWang1 mentioned this issue Feb 23, 2022
Closed
SergeySmirnov-Akvelon added a commit to SergeySmirnov-Akvelon/winforms that referenced this issue Feb 23, 2022
@SergeySmirnov-Akvelon
Fix Exception when clicking on the value of PropertyGrid's property u…
79d9704 
…nder JAWS tool dotnet#6704

The issue is reproduced because for "FragmentRoot" we return  "PropertyGridView.AccessibilityObject" and not "PropertyGrid.AccessibilityObject".

Now "FragmentRoot" returns "PropertyGrid.AccessibilityObject". This matches the behavior of other accessibility objects in the PropertyGrid.
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Feb 23, 2022
@ghost ghost removed this from the 7.0 Preview3 milestone Feb 23, 2022
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Feb 23, 2022
@RussKie
Copy link
Member

RussKie commented Feb 23, 2022

@merriemcgaw do we need to service this?

@dotnet dotnet deleted a comment Feb 23, 2022
@merriemcgaw
Copy link
Member

@SergeySmirnov-Akvelon @Tanya-Solyanik did this bug get in 6.0? If so let's fix it in just 6.0, nothing lower.

@ghost
Copy link

ghost commented Feb 24, 2022

Hi @merriemcgaw, it looks like you just commented on a closed issue. The team will most probably miss it.
If you have a question - consider opening a new discussion thread. Alternatively, you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

SergeySmirnov-Akvelon added a commit to SergeySmirnov-Akvelon/winforms that referenced this issue Feb 25, 2022
@SergeySmirnov-Akvelon
Fix Exception when clicking on the value of PropertyGrid's property u…
be6bb3f 
…nder JAWS tool dotnet#6704 (port to 6.0)

The issue is reproduced because for "FragmentRoot" we return  "PropertyGridView.AccessibilityObject" and not "PropertyGrid.AccessibilityObject".

Now "FragmentRoot" returns "PropertyGrid.AccessibilityObject". This matches the behavior of other accessibility objects in the PropertyGrid.
Merged
@ghost ghost added 🚧 work in progress Work that is current in progress and removed 🚧 work in progress Work that is current in progress labels Feb 25, 2022
dreddy-work pushed a commit that referenced this issue Mar 1, 2022
@SergeySmirnov-Akvelon
Fix Exception when clicking on the value of PropertyGrid's property u…
90826b1 
…nder JAWS tool #6704 (port to 6.0) (#6762)

The issue is reproduced because for "FragmentRoot" we return  "PropertyGridView.AccessibilityObject" and not "PropertyGrid.AccessibilityObject".

Now "FragmentRoot" returns "PropertyGrid.AccessibilityObject". This matches the behavior of other accessibility objects in the PropertyGrid.
@Ashley-Li
Copy link

Verified this issue in .Net 6.0.202 service build, it is fixed that no exception was throwing when clicking using mouse or press "Tab" keyboard on the value of propertyGrid's property. Please see below test result:
result

@John-Qiao
Copy link
Member

Verified with .NET SDK 7.0.100-preview.4.22201.8 build, this issue is fixed as same as above test result.

@John-Qiao
Copy link
Member

Verified with .NET SDK 7.0.100-preview.3.22179.4 build, this issue is fixed as same as above test result.

@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vladimir-krestov vladimir-krestov

Labels
Priority:1 Work that is critical for the release, but we could probably ship without tenet-accessibility MAS violation, UIA issue; problems with accessibility standards
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing a JAWS exception in a PropertyGrid SergeySmirnov-Akvelon/winforms
8 participants
@RussKie @Tanya-Solyanik @merriemcgaw @Olina-Zhang @John-Qiao @vladimir-krestov @Ashley-Li @Amy-Li03