Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a JAWS exception in a PropertyGrid #6747

Conversation

SergeySmirnov-Akvelon
Copy link
Contributor

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon commented Feb 23, 2022

Fixes #6704

Proposed changes

  • The issue is reproduced because for FragmentRoot we return PropertyGridView.AccessibilityObject and not PropertyGrid.AccessibilityObject.
  • Now FragmentRoot returns PropertyGrid.AccessibilityObject. This matches the behavior of other accessibility objects in the PropertyGrid.

Customer Impact

Before fix:
154419615-f42458cc-c068-4610-94a3-61cfb5235bf8

After fix:
Issue-6704

Regression?

  • Yes

Risk

  • Minimal

Test methodology

  • CTI team
  • Unit-tests

Accessibility testing

  • JAWS
  • NVDA
  • Narrator
  • Accessibility Insights
  • Inspect

Test environment(s)

  • Microsoft Windows [Version 10.0.19044.1466]
  • .NET Core SDK: 7.0.0-preview.3.22121.13
Microsoft Reviewers: Open in CodeFlow

…nder JAWS tool dotnet#6704

The issue is reproduced because for "FragmentRoot" we return  "PropertyGridView.AccessibilityObject" and not "PropertyGrid.AccessibilityObject".

Now "FragmentRoot" returns "PropertyGrid.AccessibilityObject". This matches the behavior of other accessibility objects in the PropertyGrid.
@dreddy-work dreddy-work added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Feb 23, 2022
@RussKie RussKie removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Feb 23, 2022
@RussKie RussKie merged commit 7bb6351 into dotnet:main Feb 23, 2022
@RussKie RussKie deleted the Issue-6704_PropertyGrid_JAWS_Exception branch February 23, 2022 22:51
@ghost ghost added this to the 7.0 Preview3 milestone Feb 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when clicking on the value of PropertyGrid's property under JAWS tool
3 participants