Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AxHosts.csproj build errors with Preview 7 SDK #11878

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

lonitra
Copy link
Member

@lonitra lonitra commented Aug 14, 2024

Related: dotnet/sdk#42699

Implemented suggestion to resolve build error when moving to use Preview 7 SDK

Microsoft Reviewers: Open in CodeFlow

@lonitra lonitra changed the title Fix BuildAssist build errors Fix AxHosts.csproj build errors Aug 14, 2024
@lonitra lonitra changed the title Fix AxHosts.csproj build errors Fix AxHosts.csproj build errors with Preview 7 SDK Aug 14, 2024
@lonitra lonitra marked this pull request as ready for review August 14, 2024 18:41
@lonitra lonitra requested a review from a team as a code owner August 14, 2024 18:41
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79183%. Comparing base (8474ec6) to head (4d9842b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11878         +/-   ##
===================================================
- Coverage   74.79643%   74.79183%   -0.00460%     
===================================================
  Files           3019        3019                 
  Lines         630018      630018                 
  Branches       46779       46779                 
===================================================
- Hits          471231      471202         -29     
- Misses        155415      155434         +19     
- Partials        3372        3382         +10     
Flag Coverage Δ
Debug 74.79183% <ø> (-0.00460%) ⬇️
integration 18.02107% <ø> (-0.01163%) ⬇️
production 47.78038% <ø> (-0.01056%) ⬇️
test 97.00859% <ø> (+0.00028%) ⬆️
unit 44.78349% <ø> (-0.00599%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra
Copy link
Member Author

lonitra commented Aug 14, 2024

cc: @jjonescz , @mthalman

@lonitra lonitra enabled auto-merge (squash) August 14, 2024 19:00
@lonitra lonitra merged commit 196c566 into dotnet:main Aug 14, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 RC1 milestone Aug 14, 2024
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lonitra lonitra deleted the buildaxhost branch August 14, 2024 20:05
paul1956 pushed a commit to paul1956/winforms that referenced this pull request Aug 15, 2024
* update to preview 7 sdk

* try disable automatic 'torn sdk detection'
paul1956 pushed a commit to paul1956/winforms that referenced this pull request Aug 15, 2024
* update to preview 7 sdk

* try disable automatic 'torn sdk detection'
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants