.NET Source-Build 9.0.100-preview.7.24407.1 August 2024 Updates

[dotnet-sb-bot]

Source-build updates for the .NET / 9.0.100-preview.7.24407.1 August 2024 release.

[ellahathaway]

No arcade version update? Is that expected?

[mthalman]

No arcade version update? Is that expected?

Oh, good catch. I'll investigate.

[mthalman]

Yep, Arcade is all current.

Here's what it should be:
https://github.com/dotnet/dotnet/blob/v9.0.0-preview.7.24405.7/src/source-manifest.json#L3-L8

Here's what it is:

sdk/src/SourceBuild/content/eng/Version.Details.xml

Lines 5 to 7 in 2c9444f

	<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="9.0.0-beta.24368.9">
	<Uri>https://github.com/dotnet/arcade</Uri>
	<Sha>b4e499d1f6e6b3a981feabfed290d99261762382</Sha>

They match.

[mthalman]

/azp run sdk-source-build

[mthalman]

This is failing in the VMR build of winforms with the following error:

D:\a\_work\1\vmr\.dotnet\sdk\9.0.100-preview.7.24407.12\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(258,5): error NETSDK1216: Package Microsoft.Net.Sdk.Compilers.Toolset is not downloaded but it is needed because your MSBuild and SDK versions are mismatched. Ensure version 9.0.100-preview.7.24407.12 of the package is available in your NuGet source feeds and then run NuGet package restore from Visual Studio or MSBuild. [D:\a\_work\1\vmr\src\winforms\src\System.Windows.Forms\tests\AxHosts\AxHosts.csproj] [D:\a\_work\1\vmr\src\winforms\src\BuildAssist\BuildAssist.msbuildproj]

binlog: winforms.zip

This is related to the changes in #42216.

Ping @sharwell and @jjonescz

For context, this PR is updating the SDK version used by the VMR to the official Preview 7 build. It's failing when building the winforms repo. It seems that the winforms repo is using the MSBuild version from VS to build rather than the SDK. See:

I would expect the winforms repo to run into this same issue if its global.json was updated to use Preview 7 SDK.

[jjonescz]

This means msbuild is some old version (e.g., 17.11 with roslyn 4.11) and SDK is a newer version (here preview 7, having analyzers referencing roslyn 4.12). In that "torn" state we automatically download a package with the corresponding compiler (4.12) that can be used during the build - otherwise analyzers could fail since they reference newer roslyn version (4.12) than the host msbuild has (4.11). The NETSDK1216 error means the package wasn't restored properly.

msbuild.exe D:\a_work\1\vmr\src\winforms\src\System.Windows.Forms\tests\AxHosts\AxHosts.csproj /p:Configuration=Release /p:Platform=AnyCPU /v:m

My guess is that this isn't running restore so specifying something like /t:Restore;Build would fix the error.
Alternatively, you could somehow ensure the msbuild.exe version matches the SDK.
Or specifying /p:BuildWithNetFrameworkHostedCompiler=false will disable this automatic "torn SDK" detection.

cc @jaredpar

[mthalman]

@JeremyKuhne - Looking for someone working in the winforms repo to help implement the recommendation from above: #42699 (comment). Can you help with that?

[JeremyKuhne]

@JeremyKuhne - Looking for someone working in the winforms repo to help implement the recommendation from above: #42699 (comment). Can you help with that?

I'm wrapping up for vacation. @lonitra can you assist @mthalman?

[lonitra]

@lonitra can you assist @mthalman?

sure thing. @mthalman what would be the best way to test whether the recommendation resolves this issue? Right now without the recommendation, building the repo does not give me this error.

[jjonescz]

what would be the best way to test whether the recommendation resolves this issue? Right now without the recommendation, building the repo does not give me this error.

Try updating global.json to point to SDK 9 preview 7, it should then fail to build with the same error.

[mthalman]

/backport to release/9.0.1xx

[github-actions]

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10421079358

[mthalman]

The latest failure from UB pipeline on the Windows leg:

repo-projects\Directory.Build.targets(562,5): error MSB3231: Unable to remove directory "D:\a\_work\1\vmr\src\wpf\artifacts\sb\". Access to the path 'Microsoft.CodeAnalysis.CSharp.dll' is denied.

This is consistently failing. It occurs in the CleanupRepo target.

[ViktorHofer]

sdk/src/SourceBuild/content/repo-projects/Directory.Build.targets

Lines 527 to 529 in 6e23b6e

	<Exec Command="$(DotnetTool) build-server shutdown --vbcscompiler"
	IgnoreStandardErrorWarningFormat="true"
	IgnoreExitCode="true" />

should take care of shutting down the build server. The caveat with that is that it doesn't work if an OOB compiler package is used. But I don't see a reference to Microsoft.Net.Compilers.Toolset.

I wonder if this coming from the new desktop OOB compiler package as wpf builds with desktop msbuild afaik.

dotnet/source-build#4175 has more details on this issue.