Skip to content

fix: [Loc] incorrect description text in MultilineStringEditor dropdown #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2019
Merged

fix: [Loc] incorrect description text in MultilineStringEditor dropdown #1211

merged 1 commit into from
Jun 24, 2019

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Jun 24, 2019 •
edited
Loading

Fixes #1076

Proposed changes

  • Add a missing new line to the resources

Screenshots

Before

Fra

After

image

Test methodology

  • Build a local version of System.Windows.Forms.Design.Editors.dll
  • Copy to C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App\3.0.0-preview6-27804-01
  • Run the app

@RussKie RussKie requested review from Olina-Zhang and a team June 24, 2019 00:33
zsd4yr
zsd4yr approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@zsd4yr zsd4yr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to replace all \r\n?

@RussKie
Copy link
Member Author

RussKie commented Jun 24, 2019 •
edited
Loading

Do we want to replace all \r\n?

I didn't find any more strings in *.resx
image

@RussKie RussKie merged commit 10e6b55 into dotnet:master Jun 24, 2019
@weltkante weltkante mentioned this pull request Jun 25, 2019
Closed
@RussKie RussKie deleted the fix_1076_incorrect_description_in_MultilineStringEditor branch February 18, 2020 03:32
@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zsd4yr zsd4yr zsd4yr approved these changes

@Olina-Zhang Olina-Zhang Awaiting requested review from Olina-Zhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Loc]The description text is not showing correctly in MultilineStringEditor drop down.
2 participants
@RussKie @zsd4yr